Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use UI Language in Web and Announcement RSS2 Feeds #9910

Open
bozana opened this issue Apr 24, 2024 · 1 comment
Open

Use UI Language in Web and Announcement RSS2 Feeds #9910

bozana opened this issue Apr 24, 2024 · 1 comment
Assignees
@bozana @pkp-dev-distribution
Labels
Bug:1:Low A bug that does not have a severe consequence or affects a small number of users. Try Me This issue might be good for a new contributor. Can you help us?
Milestone
3.5.0 LTS

Comments

@bozana
Copy link
Collaborator

bozana commented Apr 24, 2024 •
edited
Loading

In RSS2 feeds, in WebFeed and AnnouncementFeed plugin, we provide localized data, but the element language contains journal primary language.
According to the https://www.rssboard.org/rss-language-codes:

The language employed in an RSS feed can be indicated in the language element,...

the language element should then also contain the UI language in the format ISO 639-1.

PRs:
webFeed: pkp/webFeed#3
ojs announcementFeed: pkp/ojs#4368
@bozana bozana added the Bug:1:Low A bug that does not have a severe consequence or affects a small number of users. label Apr 24, 2024
@bozana bozana modified the milestones: 3.4.0-x, 3.5.0 LTS Apr 24, 2024
@bozana bozana mentioned this issue Apr 24, 2024
Closed
@bozana bozana added the Try Me This issue might be good for a new contributor. Can you help us? label Jun 13, 2024
bozana added a commit to bozana/webFeed that referenced this issue Jul 16, 2024
@bozana
pkp/pkp-lib#9910 Use UI Language in Web Feeds
664a777
@bozana bozana mentioned this issue Jul 16, 2024
Open
bozana added a commit to bozana/ojs that referenced this issue Jul 16, 2024
@bozana
pkp/pkp-lib#9910 Use UI Language in Announcement Feeds
b933268
@bozana bozana mentioned this issue Jul 16, 2024
Open
@bozana
Copy link
Collaborator Author

bozana commented Jul 16, 2024

Hi @jonasraoni, could you please review the PRs above?
Thanks a lot!

bozana added a commit to bozana/webFeed that referenced this issue Jul 17, 2024
@bozana
pkp/pkp-lib#9910 Use UI Language in Web Feeds
458ebd8
bozana added a commit to bozana/ojs that referenced this issue Jul 17, 2024
@bozana
pkp/pkp-lib#9910 Use UI Language in Announcement Feeds
d74620c
bozana added a commit to bozana/webFeed that referenced this issue Jul 18, 2024
@bozana
pkp/pkp-lib#9910 Use UI Language in Web Feeds
b4ca57f
@bozana bozana self-assigned this Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bozana bozana

@pkp-dev-distribution pkp-dev-distribution

Labels
Bug:1:Low A bug that does not have a severe consequence or affects a small number of users. Try Me This issue might be good for a new contributor. Can you help us?
Projects
None yet
Milestone
3.5.0 LTS
Development

No branches or pull requests
2 participants
@bozana @pkp-dev-distribution