pkp/pkp-lib#9753 [main] Update jquery, jquery-ui and chart.js to address security vulnerability reports #10168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
blesildaramirez
force-pushed
the
i9753-main
branch
from
91bb849
to
3fef473
Compare
This was referenced Jul 5, 2024
blesildaramirez
force-pushed
the
i9753-main
branch
from
3fef473
to
5ecdd67
Compare
blesildaramirez
force-pushed
the
i9753-main
branch
3 times, most recently
from
c6d4d94
to
7c81acf
Compare
blesildaramirez
force-pushed
the
i9753-main
branch
from
7c81acf
to
afa3f20
Compare
| @@ -16,6 +16,7 @@ | |||
|
|
|||
| namespace PKP\plugins; | |||
|
|
|||
| use Illuminate\Support\Facades\Cache; | |||
| use APP\core\Application; | |||
There was a problem hiding this comment.
Not sure why this was needed?
There was a problem hiding this comment.
This line is failing when we don't import this. It's used for getting download statistics which is why I was able to replicate the issue, because I was testing the chart.js version upgrade on the download statistics graph.
lib/weblateLanguages/languages.json
Outdated
| @@ -0,0 +1 @@ | |||
| {"aa":"Afar","ab":"Abkhazian","abr":"Abron","ace":"Achinese","ach":"Acoli","ada":"Adangme","ady":"Adyghe","ae":"Avestan","aeb":"Tunisian Arabic","af":"Afrikaans","afh":"Afrihili","aii":"Assyrian Neo-Aramaic","ain":"Ainu","ak":"Akan","akk":"Akkadian","ale":"Aleut","aln":"Gheg Albanian","alt":"Southern Altai","am":"Amharic","an":"Aragonese","ang":"Old English","anp":"Angika","apc":"Arabic (Levantine)","ar":"Arabic","ar_BH":"Arabic (Bahrain)","ar_DZ":"Arabic (Algeria)","ar_EG":"Arabic (Egypt)","ar_KW":"Arabic (Kuwait)","ar_LY":"Arabic (Libya)","ar_MA":"Arabic (Morocco)","ar_SA":"Arabic (Saudi Arabia)","ar_XB":"Arabic (Pseudo-Bidi)","ar_YE":"Arabic (Yemen)","arc":"Aramaic","arn":"Mapuche","arp":"Arapaho","arq":"Algerian Arabic","ars":"Najdi Arabic","arw":"Arawak","arz":"Egyptian Arabic","as":"Assamese","asa":"Asu","ast":"Asturian","av":"Avaric","avk":"Kotava","awa":"Awadhi","ay":"Aymara","ayc":"Aymara (Southern)","az":"Azerbaijani","azb":"Azerbaijani (Southern)","ba":"Bashkir","bal":"Baluchi","ban":"Balinese","bar":"Bavarian","bas":"Basaa","bbc":"Batak Toba","bci":"Baoul\u00e9","be":"Belarusian","be_Latn":"Belarusian (Latin)","bej":"Beja","bem":"Bemba","ber":"Berber","bew":"Betawi","bez":"Bena","bg":"Bulgarian","bgc":"Haryanvi","bgn":"Western Balochi","bh":"Bhojpuri","bhb":"Bhili","bhi":"Bhilali","bho":"Bhojpuri","bi":"Bislama","bik":"Bikol","bin":"Bini","bjj":"Kanauji","bjn":"Banjar","bla":"Siksika","blo":"Anii","bm":"Bambara","bn":"Bangla","bn_BD":"Bangla (Bangladesh)","bn_IN":"Bangla (India)","bnt":"Bantu (Other)","bo":"Tibetan","bo_CN":"Tibetan (China)","bqi":"Bakhtiari","br":"Breton","bra":"Braj","brb":"Brao","brh":"Brahui","brx":"Bodo","bs":"Bosnian","bs_Cyrl":"Bosnian (Cyrillic)","bs_Latn":"Bosnian (Latin)","bua":"Buriat","bug":"Buginese","bum":"Bulu","byn":"Blin","ca":"Catalan","ca@valencia":"Valencian","ca_AD":"Catalan (Andorra)","cad":"Caddo","cak":"Kaqchikel","car":"Carib","ce":"Chechen","ceb":"Cebuano","cgg":"Chiga","ch":"Chamorro","chb":"Chibcha","chg":"Chagatai","chk":"Chuukese","chm":"Mari","chn":"Chinook Jargon","cho":"Choctaw","chp":"Chipewyan","chr":"Cherokee","chy":"Cheyenne","ckb":"Central Kurdish","ckb_IQ":"Central Kurdish (Iraq)","ckb_IR":"Central Kurdish (Iran)","cnr":"Montenegrin","cnr_Cyrl":"Montenegrin (Cyrillic)","co":"Corsican","cop":"Coptic","cpe":"Creoles and pidgins (English based)","cpf":"Creoles and pidgins (French-based)","cpp":"Creoles and pidgins (Portuguese-based)","cr":"Cree","crh":"Crimean Tatar","crp":"Creoles and pidgins","cs":"Czech","csb":"Kashubian","cu":"Church Slavic","cv":"Chuvash","cy":"Welsh","da":"Danish","dak":"Dakota","dar":"Dargwa","dcc":"Deccan","de":"German","de@formal":"German (formal)","de@informal":"German (informal)","de_1901":"German (Traditional German orthography)","de_AT":"German (Austria)","de_CH":"German (Switzerland)","de_LU":"German (Luxembourg)","del":"Delaware","den":"Slave","dgr":"Dogrib","din":"Dinka","dje":"Zarma","dnj":"Dan","dnk":"Dengka","doi":"Dogri","dry":"Darai","dsb":"Lower Sorbian","dua":"Duala","dum":"Middle Dutch","dv":"Divehi","dyu":"Dyula","dz":"Dzongkha","ee":"Ewe","efi":"Efik","egl":"Emilian","egy":"Ancient Egyptian","eka":"Ekajuk","el":"Greek","elx":"Elamite","en":"English","en@pirate":"English (Pirate)","en_AU":"English (Australia)","en_CA":"English (Canada)","en_GB":"English (United Kingdom)","en_IE":"English (Ireland)","en_IN":"English (India)","en_NZ":"English (New Zealand)","en_PH":"English (Philippines)","en_Shaw":"English (Shavian)","en_Shaw_GB":"English (Shavian, United Kingdom)","en_Shaw_US":"English (Shavian, United States)","en_US":"English (United States)","en_XA":"English (Pseudo-Accents)","en_ZA":"English (South Africa)","en_devel":"English (DEVEL)","enm":"Middle English","eo":"Esperanto","es":"Spanish","es@formal":"Spanish (formal)","es@informal":"Spanish (informal)","es_419":"Spanish (Latin America)","es_AR":"Spanish (Argentina)","es_BO":"Spanish (Bolivia)","es_CL":"Spanish (Chile)","es_CO":"Spanish (Colombia)","es_CR":"Spanish (Costa Rica)","es_CU":"Spanish (Cuba)","es_DO":"Spanish (Dominican Republic)","es_EC":"Spanish (Ecuador)","es_MX":"Spanish (Mexico)","es_NI":"Spanish (Nicaragua)","es_PA":"Spanish (Panama)","es_PE":"Spanish (Peru)","es_PR":"Spanish (Puerto Rico)","es_SV":"Spanish (El Salvador)","es_US":"Spanish (United States)","es_UY":"Spanish (Uruguay)","es_VE":"Spanish (Venezuela)","et":"Estonian","eu":"Basque","ewo":"Ewondo","ext":"Extremaduran","fa":"Persian","fa_AF":"Persian (Afghanistan)","fan":"Fang","fat":"Fanti","fbl":"Bikol (West Albay)","ff":"Fulah","ffm":"Fulfulde (Maasina)","fi":"Finnish","fil":"Filipino","fj":"Fijian","fo":"Faroese","fon":"Fon","fr":"French","fr@formal":"French (formal)","fr@informal":"French (informal)","fr_AG":"French (Antigua & Barbuda)","fr_BE":"French (Belgium)","fr_CA":"French (Canada)","fr_CH":"French (Switzerland)","fr_LU":"French (Luxembourg)","fr_SN":"French (Senegal)","frc":"Cajun French","frk":"Frankish","frm":"Middle French","fro":"Old French","frp":"Arpitan","frr":"Northern Frisian","frs":"Eastern Frisian","fuq":"Fulfulde (Central-Eastern Niger)","fur":"Friulian","fuv":"Fulfulde (Nigerian)","fvr":"Fur","fy":"Western Frisian","ga":"Irish","gaa":"Ga","gan":"Gan Chinese","gay":"Gayo","gba":"Gbaya","gbm":"Garhwali","gd":"Scottish Gaelic","gez":"Geez","gil":"Gilbertese","gl":"Galician","glk":"Gilaki","gmh":"Middle High German","gn":"Guarani","goh":"Old High German","gom":"Goan Konkani","gon":"Gondi","gor":"Gorontalo","got":"Gothic","grb":"Grebo","grc":"Ancient Greek","gsw":"Swiss German","gu":"Gujarati","gu_IN":"Gujarati (India)","guc":"Wayuu","gug":"Guarani","gum":"Guambiano","gun":"Guaran\u00ed (Mby\u00e1)","gur":"Frafra","guw":"Gun","guz":"Gusii","gv":"Manx","gwi":"Gwich\u02bcin","ha":"Hausa","hai":"Haida","hak":"Hakka Chinese","haw":"Hawaiian","haz":"Hazaragi","he":"Hebrew","he_IL":"Hebrew (Israel)","hi":"Hindi","hi@hinglish":"Hindi (Hinglish)","hi_Latn":"Hindi (Latin)","hil":"Hiligaynon","hit":"Hittite","hmn":"Hmong","hne":"Chhattisgarhi","hnj":"Hmong Njua","hno":"Hindko (Northern)","ho":"Hiri Motu","hoc":"Ho","hoj":"Hadothi","hr":"Croatian","hrx":"Hunsrik","hsb":"Upper Sorbian","hsn":"Xiang Chinese","ht":"Haitian Creole","hu":"Hungarian","hup":"Hupa","hus":"Huastec","hy":"Armenian","hz":"Herero","ia":"Interlingua","iba":"Iban","ibb":"Ibibio","id":"Indonesian","ie":"Interlingue","ig":"Igbo","ii":"Sichuan Yi","ik":"Inupiaq","ilo":"Iloko","inh":"Ingush","io":"Ido","is":"Icelandic","it":"Italian","it@formal":"Italian (formal)","it@informal":"Italian (informal)","it_CH":"Italian (Switzerland)","iu":"Inuktitut","ja":"Japanese","ja_KS":"Japanese (KS)","jam":"Jamaican Creole English","jbo":"Lojban","jgo":"Ngomba","jmc":"Machame","jpr":"Judeo-Persian","jrb":"Judeo-Arabic","jv":"Javanese","ka":"Georgian","kaa":"Kara-Kalpak","kab":"Kabyle","kac":"Kachin","kaj":"Jju","kam":"Kamba","kaw":"Kawi","kbd":"Kabardian","kcg":"Tyap","kde":"Makonde","kea":"Kabuverdianu","kfy":"Kumaoni","kg":"Kongo","kha":"Khasi","khn":"Khandesi","kho":"Khotanese","ki":"Kikuyu","kj":"Kuanyama","kk":"Kazakh","kk_Latn":"Kazakh (Latin)","kkj":"Kako","kl":"Kalaallisut","kln":"Kalenjin","km":"Khmer","kmb":"Kimbundu","kmr":"Kurdish","kmr_Latn":"Kurdish (Latin)","kn":"Kannada","ko":"Korean","kok":"Konkani","kos":"Kosraean","kpe":"Kpelle","kr":"Kanuri","krc":"Karachay-Balkar","kri":"Krio","krl":"Karelian","kru":"Kurukh","ks":"Kashmiri","ksb":"Shambala","ksh":"Colognian","ku":"Kurdish","kum":"Kumyk","kut":"Kutenai","kv":"Komi","kw":"Cornish","kxm":"Khmer (Northern)","ky":"Kyrgyz","la":"Latin","lad":"Ladino","lag":"Langi","laj":"Lango (Uganda)","lam":"Lamba","lb":"Luxembourgish","lez":"Lezghian","lfn":"Lingua Franca Nova","lg":"Ganda","li":"Limburgish","lij":"Ligurian","ljp":"Lampung Api","lki":"Laki","lkt":"Lakota","lmn":"Lambadi","lmo":"Lombard","ln":"Lingala","lo":"Lao","lol":"Mongo","loz":"Lozi","lrc":"Northern Luri","lt":"Lithuanian","ltg":"Latgalian","lu":"Luba-Katanga","lua":"Luba-Lulua","lui":"Luiseno","lun":"Lunda","luo":"Luo","lus":"Mizo","luy":"Luyia","luz":"Luri (Southern)","lv":"Latvian","lv@formal":"Latvian (formal)","lv@informal":"Latvian (informal)","lzh":"Literary Chinese","mad":"Madurese","mag":"Magahi","mai":"Maithili","mak":"Makasar","man":"Mandingo","mas":"Masai","mdf":"Moksha","mdh":"Maguindanaon","mdr":"Mandar","men":"Mende","mer":"Meru","mfa":"Malay (Pattani)","mfe":"Morisyen","mg":"Malagasy","mga":"Middle Irish","mgh":"Makhuwa-Meetto","mgo":"Meta\u02bc","mh":"Marshallese","mhr":"Mari","mi":"M\u0101ori","mia":"Miami","mic":"Mi'kmaq","min":"Minangkabau","mjw":"Karbi","mk":"Macedonian","ml":"Malayalam","mn":"Mongolian","mnc":"Manchu","mni":"Manipuri","mnk":"Mandingo","mnw":"Mon","moe":"Innu-aimun","moh":"Mohawk","mos":"Mossi","mr":"Marathi","mrh":"Mara","ms":"Malay","ms_Arab":"Malay (Arabic)","mt":"Maltese","mtr":"Mewari","mus":"Muscogee","mwl":"Mirandese","mwr":"Marwari","my":"Burmese","my@Zawgyi":"Burmese (Zawgyi)","myv":"Erzya","myx":"Masaaba","mzn":"Mazanderani","na":"Nauru","nah":"Nahuatl","nan_Hant":"Min Nan Chinese (Traditional)","nan_Latn":"Min Nan Chinese (Latin)","nap":"Neapolitan","naq":"Nama","nb_NO":"Norwegian Bokm\u00e5l (Norway)","nd":"North Ndebele","ndc":"Ndau","nds":"Low German","ne":"Nepali","new":"Newari","ng":"Ndonga","ngl":"Lomwe","nia":"Nias","niu":"Niuean","nl":"Dutch","nl@formal":"Dutch (formal)","nl@informal":"Dutch (informal)","nl_BE":"Dutch (Belgium)","nn":"Norwegian Nynorsk","nnh":"Ngiemboon","nod":"Thai (Northern)","noe":"Nimadi","nog":"Nogai","non":"Old Norse","nqo":"N\u2019Ko","nr":"South Ndebele","nso":"Northern Sotho","nuk":"Nuu-chah-nulth","nv":"Navajo","nwc":"Classical Newari","ny":"Nyanja","nym":"Nyamwezi","nyn":"Nyankole","nyo":"Nyoro","nzi":"Nzima","oc":"Occitan","oj":"Ojibwa","om":"Oromo","or":"Odia","os":"Ossetic","osa":"Osage","ota":"Ottoman Turkish","otk":"Kokturk","ovd":"Elfdalian","pa":"Punjabi","pa_PK":"Punjabi (Pakistan)","pag":"Pangasinan","pal":"Pahlavi","pam":"Pampanga","pap":"Papiamento","pau":"Palauan","pbb":"P\u00e1ez","pcm":"Nigerian Pidgin","pdt":"Plautdietsch","peo":"Old Persian","phn":"Phoenician","pi":"Pali","pl":"Polish","pl@formal":"Polish (formal)","pl@informal":"Polish (informal)","pms":"Piedmontese","pon":"Pohnpeian","prg":"Prussian","pro":"Old Proven\u00e7al","ps":"Pashto","pt":"Portuguese","pt@formal":"Portuguese (formal)","pt@informal":"Portuguese (informal)","pt_AO":"Portuguese (Angola)","pt_BR":"Portuguese (Brazil)","pt_BR@formal":"Portuguese (Brazil, formal)","pt_BR@informal":"Portuguese (Brazil, informal)","pt_PT":"Portuguese (Portugal)","qdt":"Eskimo (Pacific Coast Alaskan)","qtp":"Gay\u00f3n","qu":"Quechua","qu_EC":"Quechua (Ecuador)","quc":"K\u02bciche\u02bc","qya":"Quenya","raj":"Rajasthani","rap":"Rapanui","rar":"Rarotongan","rcf":"R\u00e9union Creole","rej":"Rejang","rhg":"Rohingya","rif":"Riffian","rkt":"Rangpuri","rm":"Romansh","rmt":"Domari","rn":"Rundi","rng":"Ronga","ro":"Romanian","ro_MD":"Romanian (Moldova)","rof":"Rombo","rom":"Romany","ru":"Russian","ru@formal":"Russian (formal)","ru@informal":"Russian (informal)","ru_UA":"Russian (Ukraine)","rue":"Rusyn","rup":"Aromanian","rw":"Kinyarwanda","rwk":"Rwa","sa":"Sanskrit","sad":"Sandawe","sah":"Sakha","sai":"South American Indian (Other)","sam":"Samaritan Aramaic","saq":"Samburu","sas":"Sasak","sat":"Santali","sc":"Sardinian","sck":"Sadri","scn":"Sicilian","sco":"Scots","sd":"Sindhi","sdh":"Southern Kurdish","se":"Northern Sami","sef":"Senoufo (Cebaara)","seh":"Sena","sel":"Selkup","ses":"Koyraboro Senni","sg":"Sango","sga":"Old Irish","sgn":"Sign Languages","sgs":"Samogitian","shi":"Tachelhit","shn":"Shan","si":"Sinhala","sid":"Sidamo","sjd":"Sami (Kildin)","sk":"Slovak","skr":"Saraiki","sl":"Slovenian","sm":"Samoan","sma":"Southern Sami","smi":"Sami","smj":"Lule Sami","sml":"Sama (Central)","smn":"Inari Sami","sms":"Skolt Sami","sn":"Shona","snk":"Soninke","so":"Somali","sog":"Sogdien","son":"Songhai","sou":"Thai (Southern)","sq":"Albanian","sr":"Serbian","sr@ijekavian":"Serbian (Ijekavian)","sr@ijekavian_Latn":"Serbian (Ijekavian, latin)","sr_Cyrl":"Serbian (Cyrillic)","sr_Latn":"Serbian (Latin)","srn":"Sranan Tongo","srr":"Serer","ss":"Swati","ssy":"Saho","st":"Southern Sotho","su":"Sundanese","suk":"Sukuma","sus":"Susu","sux":"Sumerian","sv":"Swedish","sw":"Swahili","sw_CD":"Swahili (Congo - Kinshasa)","sw_TZ":"Swahili (Tanzania)","swg":"Swabian","swv":"Shekhawati","sxu":"Saxon (Upper)","syc":"Classical Syriac","syl":"Sylheti","syr":"Syriac","szl":"Silesian","ta":"Tamil","ta_LK":"Tamil (Sri Lanka)","tcy":"Tulu","te":"Telugu","tem":"Timne","teo":"Teso","ter":"Tereno","tet":"Tetum","tg":"Tajik","th":"Thai","ti":"Tigrinya","tig":"Tigre","tiv":"Tiv","tk":"Turkmen","tkl":"Tokelau","tl":"Tagalog","tlh":"Klingon","tlh-qaak":"Klingon (Qaak)","tli":"Tlingit","tly":"Talysh","tmh":"Tamashek","tn":"Tswana","to":"Tongan","tog":"Nyasa Tonga","tok":"Toki Pona","tpi":"Tok Pisin","tr":"Turkish","trv":"Taroko","ts":"Tsonga","tsg":"Tausug","tsi":"Tsimshian","tsj":"Tshangla","tt":"Tatar","tt@iqtelif":"Tatar (IQTElif)","tts":"Thai (Northeastern)","tum":"Tumbuka","tvl":"Tuvalu","tw":"Twi","ty":"Tahitian","tyv":"Tuvinian","tzj":"Tz'utujil","tzl":"Talossan","tzm":"Central Atlas Tamazight","udm":"Udmurt","ug":"Uyghur","uga":"Ugaritic","uk":"Ukrainian","umb":"Umbundu","und":"Unknown language","unr":"Mundari","ur":"Urdu","ur_IN":"Urdu (India)","ur_PK":"Urdu (Pakistan)","uz":"Uzbek","uz_Latn":"Uzbek (Latin)","vai":"Vai","ve":"Venda","vec":"Venetian","vi":"Vietnamese","vls":"West Flemish","vmf":"Main-Franconian","vmw":"Makhuwa","vo":"Volap\u00fck","vot":"Votic","vro":"V\u00f5ro","vun":"Vunjo","wa":"Walloon","wae":"Walser","wal":"Wolaytta","war":"Waray","was":"Washo","wbq":"Waddar","wbr":"Wagdi","wen":"Sorbian","wep":"Westphalien","wo":"Wolof","wtm":"Mewati","wuu":"Wu Chinese","wuu_Hans":"Wu Chinese (Simplified)","wuu_Hant":"Wu Chinese (Traditional)","xal":"Kalmyk","xh":"Xhosa","xnr":"Kangri","xog":"Soga","yao":"Yao","yap":"Yapese","yi":"Yiddish","yo":"Yoruba","yua":"Yucateco","yue_Hans":"Cantonese (Simplified)","yue_Hant":"Cantonese (Traditional)","za":"Zhuang","zap":"Zapotec","zbl":"Blissymbols","zen":"Zenaga","zgh":"Standard Moroccan Tamazight","zh_Hans":"Chinese (Simplified)","zh_Hans_SG":"Chinese (Simplified, Singapore)","zh_Hant":"Chinese (Traditional)","zh_Hant_HK":"Chinese (Traditional, Hong Kong SAR China)","zh_Latn":"Chinese (Latin)","zu":"Zulu","zun":"Zuni","zza":"Zaza"} | |||
There was a problem hiding this comment.
Where this is coming from? :-)
There was a problem hiding this comment.
I'll undo this one.. this I don't think I should've committed this 🤔
There was a problem hiding this comment.
This is now removed. I accidentally included it when I was fixing some conflicts during rebase.
| pkpUsageStats.config.chartType === 'bar' | ||
| ? 'transparent' | ||
| : 'rgba(0,0,0,0.05)', | ||
| drawTicks: false, |
There was a problem hiding this comment.
Oki.. looking pretty much as before, right? :-)
There was a problem hiding this comment.
Here's the comparison of the chart displays.
Bar Chart
Line Chart
Hi @bozana , FYI on the new look of the charts for the download statistics on the article frontend page.
There was a problem hiding this comment.
Thank you for the screenshots - will also tag @Devika008 for feedback. The images with newer versions would be how it would look going forward. Please let us know if you see something worrying.
Personally having the color filled under the line chart makes it nicer. But lets see what Devika thinks.
There was a problem hiding this comment.
Hi @jardakotesovec and @blesildaramirez,
The graphs look great to me. Honestly, to me too having the colour under the line graphs makes it easier to read the line graphs. But what helps more is that having a darker colour line at the end of the coloured line graph like the image below. makes it super easy to read.
There was a problem hiding this comment.
Hi @Devika008 , thanks for your inputs. I updated the line chart and it now looks like this:
The graph now looks almost the same as before, plus your suggestion to thicken the line stroke.
Please let me know if this looks good from your end and I will update this PR. This Thanks!
blesildaramirez
force-pushed
the
i9753-main
branch
from
afa3f20
to
6910fc4
Compare
blesildaramirez
force-pushed
the
i9753-main
branch
from
6910fc4
to
b5e7622
Compare
blesildaramirez
changed the title
7 tasks
…ui and jquery-validation
blesildaramirez
force-pushed
the
i9753-main
branch
from
211df3b
to
3a03970
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For main branch, we need to:
usage-stats-chart.jsto make it compatible with the new versionNotes:
components/jqueryandcomponents/jqueryuiin composer dependencies, and instead used npm to install jquery, jquery-ui. We also removedlib/pkp/js/lib/jquery/plugins/validate(jquery-validation) andlib/pkp/js/lib/Chart.js&/lib/pkp/js/lib/Chart.min.js(chart.js) and also used npm to improve handling the version upgrades moving forward. Note that these npm dependencies are handled on the ojs/omp/ops app level.js/buildfolder for the mentioned dependencies, so changing the paths when adding these scripts in the frontend were necessary.The following are the new URL/paths for these dependencies:
js/build/jquery/js/build/jquery-ui/js/build/jquery-validation/js/build/chart.js/