pkp/pkp-lib#7167 Fix duplicated user settings and remove unused fields #7464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasraoni
commented
Nov 21, 2021
jonasraoni
force-pushed
the
bugfix/master/7167-fix-user-settings
branch
from
6a6eb8b
to
7ff4422
Compare
jonasraoni
commented
Nov 21, 2021
|
@asmecher I've tried to decrease the running time of Travis with some settings, but didn't change that much Also, what about removing the stale branches in pkp-lib, ojs, etc? |
jonasraoni
force-pushed
the
bugfix/master/7167-fix-user-settings
branch
from
065cff5
to
ae899cd
Compare
asmecher
reviewed
Nov 23, 2021
classes/migration/upgrade/v3_4_0/I7167_RemoveDuplicatedUserSettingsAndDeprecatedFields.inc.php
Outdated
Show resolved
Hide resolved
jonasraoni
force-pushed
the
bugfix/master/7167-fix-user-settings
branch
from
1da8fed
to
348258d
Compare
asmecher
reviewed
Dec 3, 2021
classes/migration/upgrade/v3_4_0/I7167_RemoveDuplicatedUserSettingsAndDeprecatedFields.inc.php
Outdated
Show resolved
Hide resolved
…pped implicitly)
…ey constraint to avoid conflicts
jonasraoni
force-pushed
the
bugfix/master/7167-fix-user-settings
branch
from
0119590
to
dd9b08a
Compare
|
@asmecher I've updated the PR to address the index, the tests are passing yet, so feel free to take a look again 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.