-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkp/pkp-lib#5716 Add new manage emails UI and remove email templates list #8407
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! The approach to associate custom templates with a default one looks simpler and cleaner than the previous one, with mailable. I left a couple of minor comments
controllers/grid/users/reviewer/form/AdvancedSearchReviewerForm.php
Outdated
Show resolved
Hide resolved
controllers/grid/users/stageParticipant/StageParticipantGridHandler.php
Outdated
Show resolved
Hide resolved
classes/migration/upgrade/v3_4_0/I5716_EmailTemplateAssignments.php
Outdated
Show resolved
Hide resolved
classes/migration/upgrade/v3_4_0/I5716_EmailTemplateAssignments.php
Outdated
Show resolved
Hide resolved
a4174d4
to
da99f3f
Compare
This commit replaces the email templates list with a new Manage Emails UI based on our new Mailables system. It includes the following changes: - Refactor relationship between mailables and email templates. All email templates now assigned to a mailable. - Adds settings page to edit and assign mailable templates - Remove email templates management list panel - Migrate existing custom templates to new discussion stage mailables - Migrate disabled email template functionality to new context settings - Add alternateTo attribute to emailTemplates.xml for extra templates - Give all email templates a name - Generate custom template keys from the name - Updates to several mailable names, descriptions, filter settings, etc.
da99f3f
to
a8bfeae
Compare
This commit replaces the email templates list with a new Manage Emails UI
based on our new Mailables system. It includes the following changes:
templates now assigned to a mailable.