Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkp/pkp-lib#5716 Add new manage emails UI and remove email templates list #8407

Merged
merged 12 commits into from
Nov 30, 2022

Conversation

NateWr
Copy link
Contributor

@NateWr NateWr commented Nov 7, 2022

This commit replaces the email templates list with a new Manage Emails UI
based on our new Mailables system. It includes the following changes:

  • Refactor relationship between mailables and email templates. All email
    templates now assigned to a mailable.
  • Adds settings page to edit and assign mailable templates
  • Remove email templates management list panel
  • Migrate existing custom templates to new discussion stage mailables
  • Migrate disabled email template functionality to new context settings
  • Add alternateTo attribute to emailTemplates.xml for extra templates
  • Give all email templates a name
  • Generate custom template keys from the name
  • Updates to several mailable names, descriptions, filter settings, etc.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Collaborator

@Vitaliy-1 Vitaliy-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The approach to associate custom templates with a default one looks simpler and cleaner than the previous one, with mailable. I left a couple of minor comments

controllers/grid/queries/QueryNotesGridHandler.php Outdated Show resolved Hide resolved
classes/emailTemplate/Collector.php Outdated Show resolved Hide resolved
classes/emailTemplate/Collector.php Show resolved Hide resolved
This commit replaces the email templates list with a new Manage Emails UI
based on our new Mailables system. It includes the following changes:

- Refactor relationship between mailables and email templates. All email
	templates now assigned to a mailable.
- Adds settings page to edit and assign mailable templates
- Remove email templates management list panel
- Migrate existing custom templates to new discussion stage mailables
- Migrate disabled email template functionality to new context settings
- Add alternateTo attribute to emailTemplates.xml for extra templates
- Give all email templates a name
- Generate custom template keys from the name
- Updates to several mailable names, descriptions, filter settings, etc.
@NateWr NateWr merged commit 4bd77b6 into pkp:main Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants