[PKP-LIB][main] #9453 Reviewer History #9920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asmecher
reviewed
Apr 30, 2024
| $this->addPolicy(new UserRolesRequiredPolicy($request), true); | ||
| $this->addPolicy(new ContextAccessPolicy($request, $roleAssignments)); | ||
|
|
||
| if ($actionName === 'getHistory') { |
There was a problem hiding this comment.
getHistory is the only function offered by this controller, right? It might be better to just remove this test entirely and always add the policy. If a later function gets added to the handler, it'll probably need the same policy -- and as it stands, the policy wouldn't be applied.
There was a problem hiding this comment.
You are right. Removed.
…ure switch removal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.