Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkp/pkp-lib#5885 updated and added new UI component #333

Merged
merged 5 commits into from
Aug 30, 2024

Conversation

touhidurabir
Copy link
Member

@touhidurabir
Copy link
Member Author

Hi @jardakotesovec , can you take a look at the PR now . I have removed any extra component and have the disable/enable now as part of slider component . But just could not make few tailwind css class work so design still a bit mess .

@jardakotesovec
Copy link
Collaborator

@touhidurabir Hi Touhidur - I see there are some changes - can you remind me is this still something to be reviewed? If so - can you just describe briefly what scenario is this addressing? Thank you

@touhidurabir
Copy link
Member Author

@jardakotesovec sorry for late reply . It's now ready for merge as was in testing pahse by hosting team . About the change, when there is no entry of numDays..... settings name in the journal/press/server_settings table , it shows the label as null days before due date . Basically in those cases we just need to show No reminder set . The requested change address that issue .

@asmecher asmecher merged commit 6dedc2b into pkp:main Aug 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants