Skip to content

Commit

Permalink
[wip] Add tests: split
Browse files Browse the repository at this point in the history
  • Loading branch information
@pkryger
pkryger committed Feb 29, 2024
1 parent ccd45ba commit 8e6a778
Showing 1 changed file with 147 additions and 96 deletions.
243 changes: 147 additions & 96 deletions test/difftastic.t.el
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

(require 'difftastic)

(ert-deftest test-difftastic--copy-tree ()
(ert-deftest difftastic--copy-tree:basic ()
(let* ((vec (make-vector 1 nil))
(bool-vec (make-bool-vector 1 nil))
(tree (cons vec bool-vec))
Expand All @@ -17,20 +17,22 @@
(should (eq (cdr tree) bool-vec))
(should-not (eq (cdr copy) bool-vec))))

(ert-deftest test-difftastic--with-temp-advice ()
(should (eval ;; macro
(ert-deftest difftastic--with-temp-advice:basic-case-removes-advice ()
(should (eval
'(difftastic--with-temp-advice
'identity :around (lambda (&rest _) t)
(identity nil))))
(should-not (identity nil))
(should-error (eval ;; macro
(should-not (identity nil)))

(ert-deftest difftastic--with-temp-advice:error-signaled-removes-advice ()
(should-error (eval
'(difftastic--with-temp-advice
'identity :around (lambda (&rest _)
(signal 'error nil))
(signal 'error "test-error"))
(identity nil))))
(should-not (identity nil)))

(ert-deftest test-difftastic--make-suggestion ()
(ert-deftest difftastic--make-suggestion:basic ()
(let ((languages '("Emacs Lisp" "C++" "Text"))
elisp-buffer c++-buffer org-buffer)
(with-temp-buffer
Expand All @@ -47,26 +49,33 @@

(should
(string= "Emacs Lisp"
(difftastic--make-suggestion languages elisp-buffer c++-buffer)))
(difftastic--make-suggestion languages
elisp-buffer c++-buffer)))
(should
(string= "Emacs Lisp"
(difftastic--make-suggestion languages elisp-buffer org-buffer)))
(difftastic--make-suggestion languages
elisp-buffer org-buffer)))
(should
(string= "Emacs Lisp"
(difftastic--make-suggestion languages org-buffer elisp-buffer)))
(difftastic--make-suggestion languages
org-buffer elisp-buffer)))
(should
(string= "C++"
(difftastic--make-suggestion languages c++-buffer org-buffer)))
(difftastic--make-suggestion languages
c++-buffer org-buffer)))
(should
(string= "C++"
(difftastic--make-suggestion languages c++-buffer elisp-buffer)))
(difftastic--make-suggestion languages
c++-buffer elisp-buffer)))
(should
(string= "C++"
(difftastic--make-suggestion languages org-buffer c++-buffer)))
(difftastic--make-suggestion languages
org-buffer c++-buffer)))
(should-not
(difftastic--make-suggestion languages org-buffer org-buffer)))))))
(difftastic--make-suggestion languages
org-buffer org-buffer)))))))

(ert-deftest test-difftastic--transform-diff-arguments ()
(ert-deftest difftastic--transform-diff-arguments:basic ()
(should (equal '(("--ignore-submodules=test-submodule")
("--context 1" "--context 2"))
(difftastic--transform-diff-arguments
Expand All @@ -75,89 +84,120 @@
"-M" "-M3" "--find-renames" "--find-renames=4"
"--ignore-submodules=test-submodule")))))

(ert-deftest test-difftastic--get-file ()
(let (file-buf temp-file)
(ert-deftest difftastic--get-file:buffer-visiting-file-no-temporary-created ()
(let (temp-file)
(unwind-protect
(progn
(with-temp-buffer
(setq temp-file (make-temp-file "difftastic.t"))
(write-region (point-min) (point-max) temp-file nil t)
(with-temp-buffer
(setq temp-file (make-temp-file "difftastic.t"))
(write-region (point-min) (point-max) temp-file nil t)
(should (equal `(,(buffer-file-name) . nil)
(difftastic--get-file "test" (current-buffer)))))
(difftastic--get-file-buf "test" (current-buffer)))))

(with-temp-buffer
(setq file-buf (difftastic--get-file "test" (current-buffer)))
(should (consp file-buf))
(should (string-match-p
(eval '(rx string-start
(literal temporary-file-directory)
"difftastic-test-"
(one-or-more (not "/"))))
(car file-buf)))
(should (equal (current-buffer) (cdr file-buf)))))

(when (and (cdr file-buf) (file-exists-p (car file-buf)))
(delete-file (car file-buf)))
(when (file-exists-p temp-file)
(delete-file temp-file)))))

(ert-deftest test-difftastic--with-temp-files ()
(let (temp-file-A temp-file-B)
(ert-deftest difftastic--get-file:buffer-not-visiting-file-temporary-created ()
(let (file-buf)
(unwind-protect
(with-temp-buffer
(setq file-buf (difftastic--get-file-buf "test" (current-buffer)))
(should (consp file-buf))
(should (string-match-p
(eval '(rx string-start
(literal temporary-file-directory)
"difftastic-test-"
(one-or-more (not "/"))))
(car file-buf)))
(should (equal (current-buffer) (cdr file-buf))))

(when (and (cdr file-buf) (file-exists-p (car file-buf)))
(delete-file (car file-buf))))))

(ert-deftest difftastic--with-file-bufs:basic-case-temporary-file-bufs-are-preserved ()
(let (temp-file-A temp-file-B temp-file-C)
(unwind-protect
(progn
(setq temp-file-A (make-temp-file "difftastic.t")
temp-file-B (make-temp-file "difftastic.t"))
temp-file-B (make-temp-file "difftastic.t")
temp-file-C (make-temp-file "difftastic.t"))
(should
(equal 42
(eval
'(difftastic--with-temp-files (file-buf-A file-buf-B)
`(difftastic--with-file-bufs (file-buf-A file-buf-B file-buf-C)
(should-not file-buf-A)
(should-not file-buf-B)
(setq file-buf-A (cons temp-file-A t)
file-buf-B (cons temp-file-B nil))
(should-not file-buf-C)
(setq file-buf-A (cons ,temp-file-A t)
file-buf-B (cons ,temp-file-B nil)
file-buf-C (cons ,temp-file-C t))
42))))
(should (file-exists-p temp-file-A))
(should (file-exists-p temp-file-B))
(should (file-exists-p temp-file-C)))

(dolist (temp-file (list temp-file-A temp-file-B temp-file-C))
(when (file-exists-p temp-file)
(delete-file temp-file))))))

(ert-deftest difftastic--with-file-bufs:error-mode-temporary-file-bufs-are-deleted ()
(let (temp-file-A temp-file-B temp-file-C)
(unwind-protect
(progn
(setq temp-file-A (make-temp-file "difftastic.t")
temp-file-B (make-temp-file "difftastic.t")
temp-file-C (make-temp-file "difftastic.t"))
(should-error
(eval
'(difftastic--with-temp-files (file-buf-A file-buf-B)
`(difftastic--with-file-bufs (file-buf-A file-buf-B file-buf-C)
(should-not file-buf-A)
(should-not file-buf-B)
(setq file-buf-A (cons temp-file-A nil)
file-buf-B (cons temp-file-B t))
(signal 'error nil))))
(should (file-exists-p temp-file-A))
(should-not (file-exists-p temp-file-B)))
(should-not file-buf-C)
(setq file-buf-A (cons ,temp-file-A t)
file-buf-B (cons ,temp-file-B nil)
file-buf-C (cons ,temp-file-C t))
(signal 'error "test-error"))))
(should-not (file-exists-p temp-file-A))
(should (file-exists-p temp-file-B))
(should-not (file-exists-p temp-file-C)))

(dolist (temp-file (list temp-file-A temp-file-B temp-file-C))
(when (file-exists-p temp-file)
(delete-file temp-file))))))

(when (file-exists-p temp-file-A)
(delete-file temp-file-A))
(when (file-exists-p temp-file-B)
(delete-file temp-file-B)))))
(ert-deftest difftastic--delete-temp-file-buf:nil-does-nothing ()
(should-not (difftastic--delete-temp-file-buf nil)))

(ert-deftest test-difftastic--delete-temp-file ()
(ert-deftest difftastic--delete-temp-file-buf:not-a-temporary-is-presered ()
(let (temp-file)
(unwind-protect
(progn
(setq temp-file (make-temp-file "difftastic.t"))
(difftastic--delete-temp-file nil)
(should (file-exists-p temp-file))
(difftastic--delete-temp-file (cons temp-file nil))
(difftastic--delete-temp-file-buf (cons temp-file nil))
(should (file-exists-p temp-file))
(difftastic--delete-temp-file (cons temp-file t))
(when (file-exists-p temp-file)
(delete-file temp-file))))))

(ert-deftest difftastic--delete-temp-file-buf:temporary-is-deleted ()
(let (temp-file)
(unwind-protect
(progn
(setq temp-file (make-temp-file "difftastic.t"))
(difftastic--delete-temp-file-buf (cons temp-file t))
(should-not (file-exists-p temp-file)))
(when (file-exists-p temp-file)
(delete-file temp-file)))))

(ert-deftest test-difftastic--build-files-command ()
(ert-deftest difftastic--build-files-command:without-lang-override ()
(should (equal
`(,difftastic-executable
"--width" "42"
"--background" ,(format "%s" (frame-parameter nil 'background-mode))
"test-file-A" "test-file-B")
(difftastic--build-files-command (cons "test-file-A" nil)
(cons "test-file-B" nil)
42)))
42))))

(ert-deftest difftastic--build-files-command:with-lang-override ()
(should (equal
`(,difftastic-executable
"--width" "42"
Expand All @@ -169,47 +209,58 @@
42
"test-language"))))

(ert-deftest test-difftastic--rerun-file-buf ()
(ert-deftest difftastic--rerun-file-buf:non-temporary-no-temporary-created ()
(let (file-buf)
(unwind-protect
(progn
(let ((rerun-alist '((file-buf-test . ("test-file" . t)))))
(let* ((rerun-alist '((file-buf-test . ("test-file" . nil))))
(orig-rerun-alist (copy-tree rerun-alist)))
(setq file-buf
(difftastic--rerun-file-buf
"test"
(alist-get 'file-buf-test rerun-alist)
rerun-alist))
(should (equal (alist-get 'file-buf-test orig-rerun-alist)
file-buf))
(should (equal orig-rerun-alist rerun-alist)))

(when (and (cdr file-buf) (file-exists-p (car file-buf)))
(delete-file (car file-buf))))))

(ert-deftest difftastic--rerun-file-buf:temporary-live-buffer-new-temporary-created ()
(let (file-buf)
(unwind-protect
(let ((rerun-alist '((file-buf-test . ("test-file" . t)))))
(with-temp-buffer
(setq file-buf
(difftastic--rerun-file-buf
"test"
(cons "test-file" nil)
rerun-alist))
(should (equal (car file-buf) "test-file"))
(should (equal
'("test-file" . t)
(alist-get 'file-buf-test rerun-alist))))

(let ((rerun-alist '((file-buf-test . ("test-file" . t))))
buffer)
(with-temp-buffer
(setq buffer (current-buffer)))
(should-error
(setq file-buf
(difftastic--rerun-file-buf
"test"
(cons "test-file" buffer)
rerun-alist)))
(should (equal (car file-buf) "test-file"))
(should (equal
'("test-file" . t)
(alist-get 'file-buf-test rerun-alist))))

(let ((rerun-alist '((file-buf-test . ("test-file" . t)))))
(with-temp-buffer
(setq file-buf
(difftastic--rerun-file-buf
"test"
(cons "test-file" (current-buffer))
rerun-alist))
(should-not (equal "test-file" (car file-buf)))
(should (file-exists-p (car file-buf)))
(should (equal file-buf
(alist-get 'file-buf-test rerun-alist))))))
(difftastic--rerun-file-buf
"test"
(cons "test-file" (current-buffer))
rerun-alist))
(should-not (equal "test-file" (car file-buf)))
(should (file-exists-p (car file-buf)))
(should (equal file-buf
(alist-get 'file-buf-test rerun-alist)))))

(when (and (cdr file-buf) (file-exists-p (car file-buf)))
(delete-file (car file-buf))))))

(ert-deftest difftastic--rerun-file-buf:temporary-non-live-buffer-error-signaled ()
(let (file-buf)
(unwind-protect
(let (buffer rerun-alist orig-rerun-alist)
(with-temp-buffer
(setq buffer (current-buffer)))

(setq rerun-alist `((file-buf-test . ("test-file" . ,buffer)))
orig-rerun-alist (copy-tree rerun-alist))
(should-error
(setq file-buf
(difftastic--rerun-file-buf
"test"
(alist-get 'file-buf-test rerun-alist)
rerun-alist)))

(should (equal orig-rerun-alist rerun-alist)))

(when (and (cdr file-buf) (file-exists-p (car file-buf)))
(delete-file (car file-buf))))))
Expand Down

0 comments on commit 8e6a778

Please sign in to comment.