Retire downstream constant packing folder #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces our downstream implementation of constant packing folder with upstream patterns. The existing pass acts as a small wrapper for the upstream logic. Also, there was a bug in the element index calculation. After the replacement, the folded constant match the outputs produced by packing at runtime.
adam-smnk
added
benchmark
adam-smnk
added
benchmark
|
Rewrite problems fixed. In the initial version, chains of packs e.g., The lowering to linalg is now a pattern such that greedy rewriter can iterate over the graph and step by step fold all the packs. Added extra test case to cover this case. No performance regression in benchmarks. |
rengolin
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces our downstream implementation of constant packing folder with upstream patterns. The existing pass selects pack ops to fold and otherwise acts as a small wrapper for the upstream logic.
Also, there was a bug in the element index calculation. After the replacement, folded constants match the outputs produced by runtime packing.