Generalize before propagation #951
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-smnk
force-pushed
the
generalize-before-propagation
branch
from
0315fc0
to
7aa3247
Compare
adam-smnk
added
benchmark
Allows better pack-unpack propagation by first generalizing linalg named ops. This is mainly due to limited support for named ops in layout propagation patterns.
Adds a custom wrapper around Linalg named ops generalization. The custom pattern exposes control over which ops should be generalized. By default, the pass filters out linalg.fill ops as layout propagation and fusion behave better when the named version is present. This improves overall IR quality after bufferization.
adam-smnk
force-pushed
the
generalize-before-propagation
branch
from
7aa3247
to
799d1cc
Compare
adam-smnk
added
benchmark
|
Most important generalization is now covered by the added folding patterns. Technically, this further named ops generalization opens up more fusion opportunities when named ops are present. For now keeping it as a draft for further investigation. |
|
Not really needed, closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.