Add a fold-add-into-dest pattern and pass #966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolfmorel
force-pushed
the
fold_add_into_dest
branch
2 times, most recently
from
87a318b
to
93f8831
Compare
rolfmorel
force-pushed
the
fold_add_into_dest
branch
from
93f8831
to
e11e15c
Compare
|
This PR is now ready for review. Do let me know if adding it to the default pipeline is appropriate and whether I added it in the right place. |
|
Could you add some lit tests? |
rolfmorel
force-pushed
the
fold_add_into_dest
branch
from
068258e
to
4efe84e
Compare
Oops - forget to push. Pushed them now. |
adam-smnk
reviewed
Sep 9, 2024
adam-smnk
reviewed
Sep 9, 2024
adam-smnk
reviewed
Sep 12, 2024
Achieves the sum of linalg.add by relying on the accumulation semantics of contraction ops w.r.t. their out/dest argument. Main value is likely to come from that a buffer allocation can be elided, in case the contraction op had its own buffer.
rolfmorel
force-pushed
the
fold_add_into_dest
branch
from
0cf7eb4
to
1837867
Compare
adam-smnk
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Achieves the sum of linalg.add by relying on the accumulation semantics of contraction ops w.r.t. their out/dest argument. Main value is likely to come from that a buffer allocation can be elided, in case the contraction op had its own buffer.