Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hoist vector transfers outside reduction and k loop #977

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Hoist vector transfers outside reduction and k loop #977

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
3536411
This pass hoists vector transfer operations of resultant matrix outs…
Nov 11, 2024
a25c754
Checking Integration Tests for hoisting pass
Nov 11, 2024
6b96637
Checking Integration Tests for hoisting pass
Nov 11, 2024
99c4588
Checking Integration Tests for hoisting pass
Nov 11, 2024
69c09bd
Checking Integration Tests for hoisting pass
Nov 11, 2024
3de0bb1
Checking Integration Tests for hoisting pass
Nov 11, 2024
ae469ca
Checking Integration Tests for hoisting pass
Nov 11, 2024
b49d72a
Checking Integration Tests for hoisting pass
Nov 12, 2024
4c37c14
Added the unit test cases
Nov 12, 2024
1fb6d33
Some clean ups to the file(s)
Nov 12, 2024
8e0aa28
Some clean ups to the file(s)
Nov 13, 2024
077792b
Code refactoring
Nov 13, 2024
a20bfe6
code re-factoring and addition of few negative test checks
Nov 14, 2024
dc1b0f2
code re-factoring and addition of few negative test checks
Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 8 additions & 16 deletions test/Integration/hoist-vector-transfer-brgemm.mlir
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,38 +3,30 @@
// RUN: diff %t.1 %t.2 | FileCheck %s --check-prefix=DIFF --allow-empty

// DIFF-NOT: {{.}}
arun-thmn marked this conversation as resolved.
Show resolved Hide resolved
#map20 = affine_map<(d0, d1, d2, d3) -> (d0, d1, d3)>
#map21 = affine_map<(d0, d1, d2, d3) -> (d0, d3, d2)>
#map22 = affine_map<(d0, d1, d2, d3) -> (d1, d2)>
module {
module {
memref.global "private" constant @__constant_24x64x64xf32 : memref<24x64x64xf32> = dense<1.000000e+00> {alignment = 64 : i64}
func.func @entry(%arg0: memref<8x24x32x64xf32>) -> memref<8x24x32x64xf32> {
%cst = arith.constant 0.000000e+00 : f32
%cst_0 = arith.constant dense<0.000000e+00> : vector<32x64xf32>
%c1 = arith.constant 1 : index
%c24 = arith.constant 24 : index
%c64 = arith.constant 64 : index
%c4 = arith.constant 4 : index
%c32 = arith.constant 32 : index
%c0 = arith.constant 0 : index
%cst = arith.constant 0.000000e+00 : f32
%0 = memref.get_global @__constant_24x64x64xf32 : memref<24x64x64xf32>
%alloc = memref.alloc() {alignment = 64 : i64} : memref<8x24x32x64xf32>
scf.forall (%arg1, %arg2) in (8, 24) {
%subview = memref.subview %alloc[%arg1, %arg2, 0, 0] [1, 1, 32, 64] [1, 1, 1, 1] : memref<8x24x32x64xf32> to memref<32x64xf32, strided<[64, 1], offset: ?>>
vector.transfer_write %cst_0, %subview[%c0, %c0] {in_bounds = [true, true]} : vector<32x64xf32>, memref<32x64xf32, strided<[64, 1], offset: ?>>
%subview_1 = memref.subview %arg0[%arg1, 0, 0, 0] [1, 24, 32, 64] [1, 1, 1, 1] : memref<8x24x32x64xf32> to memref<24x32x64xf32, strided<[2048, 64, 1], offset: ?>>
linalg.fill ins(%cst : f32) outs(%subview : memref<32x64xf32, strided<[64, 1], offset: ?>>)
%subview_0 = memref.subview %arg0[%arg1, 0, 0, 0] [1, 24, 32, 64] [1, 1, 1, 1] : memref<8x24x32x64xf32> to memref<24x32x64xf32, strided<[2048, 64, 1], offset: ?>>
scf.for %arg3 = %c0 to %c32 step %c4 {
scf.for %arg4 = %c0 to %c64 step %c64 {
%subview_2 = memref.subview %subview[%arg3, %arg4] [4, 64] [1, 1] : memref<32x64xf32, strided<[64, 1], offset: ?>> to memref<4x64xf32, strided<[64, 1], offset: ?>>
%subview_1 = memref.subview %subview[%arg3, %arg4] [4, 64] [1, 1] : memref<32x64xf32, strided<[64, 1], offset: ?>> to memref<4x64xf32, strided<[64, 1], offset: ?>>
scf.for %arg5 = %c0 to %c24 step %c1 {
scf.for %arg6 = %c0 to %c64 step %c1 {
%subview_3 = memref.subview %subview_1[%arg5, %arg3, %arg6] [1, 4, 1] [1, 1, 1] : memref<24x32x64xf32, strided<[2048, 64, 1], offset: ?>> to memref<1x4x1xf32, strided<[2048, 64, 1], offset: ?>>
%subview_4 = memref.subview %0[%arg5, %arg6, %arg4] [1, 1, 64] [1, 1, 1] : memref<24x64x64xf32> to memref<1x1x64xf32, strided<[4096, 64, 1], offset: ?>>
%1 = vector.transfer_read %subview_3[%c0, %c0, %c0], %cst {in_bounds = [true, true, true]} : memref<1x4x1xf32, strided<[2048, 64, 1], offset: ?>>, vector<1x4x1xf32>
%2 = vector.transfer_read %subview_4[%c0, %c0, %c0], %cst {in_bounds = [true, true, true]} : memref<1x1x64xf32, strided<[4096, 64, 1], offset: ?>>, vector<1x1x64xf32>
%3 = vector.transfer_read %subview_2[%c0, %c0], %cst {in_bounds = [true, true]} : memref<4x64xf32, strided<[64, 1], offset: ?>>, vector<4x64xf32>
%4 = vector.contract {indexing_maps = [#map20, #map21, #map22], iterator_types = ["reduction", "parallel", "parallel", "reduction"], kind = #vector.kind<add>} %1, %2, %3 : vector<1x4x1xf32>, vector<1x1x64xf32> into vector<4x64xf32>
vector.transfer_write %4, %subview_2[%c0, %c0] {in_bounds = [true, true]} : vector<4x64xf32>, memref<4x64xf32, strided<[64, 1], offset: ?>>
%subview_2 = memref.subview %subview_0[%arg5, %arg3, %arg6] [1, 4, 1] [1, 1, 1] : memref<24x32x64xf32, strided<[2048, 64, 1], offset: ?>> to memref<1x4x1xf32, strided<[2048, 64, 1], offset: ?>>
%subview_3 = memref.subview %0[%arg5, %arg6, %arg4] [1, 1, 64] [1, 1, 1] : memref<24x64x64xf32> to memref<1x1x64xf32, strided<[4096, 64, 1], offset: ?>>
linalg.batch_reduce_matmul ins(%subview_2, %subview_3 : memref<1x4x1xf32, strided<[2048, 64, 1], offset: ?>>, memref<1x1x64xf32, strided<[4096, 64, 1], offset: ?>>) outs(%subview_1 : memref<4x64xf32, strided<[64, 1], offset: ?>>)
}
}
}
Expand Down