Skip to content

Commit

Permalink
feat: add HOUR support for time partitioning interval (googleapis#91)
Browse files Browse the repository at this point in the history
* feat: add HOUR support for time partitioning interval
  • Loading branch information
shollyman authored May 14, 2020
1 parent 834e2c0 commit 0dd90b9
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
5 changes: 3 additions & 2 deletions google/cloud/bigquery/table.py
Original file line number Diff line number Diff line change
Expand Up @@ -583,8 +583,6 @@ def partitioning_type(self):
"""Union[str, None]: Time partitioning of the table if it is
partitioned (Defaults to :data:`None`).
The only partitioning type that is currently supported is
:attr:`~google.cloud.bigquery.table.TimePartitioningType.DAY`.
"""
warnings.warn(
"This method will be deprecated in future versions. Please use "
Expand Down Expand Up @@ -1980,6 +1978,9 @@ class TimePartitioningType(object):
DAY = "DAY"
"""str: Generates one partition per day."""

HOUR = "HOUR"
"""str: Generates one partition per hour."""


class TimePartitioning(object):
"""Configures time-based partitioning for a table.
Expand Down
4 changes: 2 additions & 2 deletions tests/unit/test_table.py
Original file line number Diff line number Diff line change
Expand Up @@ -1024,11 +1024,11 @@ def test_time_partitioning_setter(self):
dataset = DatasetReference(self.PROJECT, self.DS_ID)
table_ref = dataset.table(self.TABLE_NAME)
table = self._make_one(table_ref)
time_partitioning = TimePartitioning(type_=TimePartitioningType.DAY)
time_partitioning = TimePartitioning(type_=TimePartitioningType.HOUR)

table.time_partitioning = time_partitioning

self.assertEqual(table.time_partitioning.type_, TimePartitioningType.DAY)
self.assertEqual(table.time_partitioning.type_, TimePartitioningType.HOUR)
# Both objects point to the same properties dict
self.assertIs(
table._properties["timePartitioning"], time_partitioning._properties
Expand Down

0 comments on commit 0dd90b9

Please sign in to comment.