-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delay dictionary realization when it's enumerated #34
Merged
dahlia
merged 1 commit into
planetarium:master
from
dahlia:avoid-dict-realization-on-enumeration
Nov 16, 2020
Merged
Delay dictionary realization when it's enumerated #34
dahlia
merged 1 commit into
planetarium:master
from
dahlia:avoid-dict-realization-on-enumeration
Nov 16, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dahlia
requested review from
earlbread,
riemannulus,
limebell and
longfin
and removed request for
a team and
earlbread
November 13, 2020 10:18
longfin
approved these changes
Nov 13, 2020
moreal
approved these changes
Nov 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
dahlia
added a commit
to dahlia/libplanet
that referenced
this pull request
Nov 16, 2020
dahlia
added a commit
to dahlia/libplanet
that referenced
this pull request
Nov 16, 2020
moreal
pushed a commit
to moreal/libplanet
that referenced
this pull request
Nov 17, 2020
moreal
pushed a commit
to moreal/libplanet
that referenced
this pull request
Nov 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continued from #34. This make latency short when a
Dictionary
having unrealized internal pairs is enumerated. The solution is to delay its realization and just enumerate its internal key–value pairs. One trick here I used to avoid key duplication (note that unrealized keys don't guarantee their uniqueness) is simply comparing with the key from the previous iteration. This trick works because the enumeration is done after keys are sorted first.Before:
After: