-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ Refactor test classes #1995
♻️ Refactor test classes #1995
Conversation
405717b
to
3d4a94a
Compare
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
@@ -45,7 +45,7 @@ public BattleArena5Test(ITestOutputHelper outputHelper) | |||
.WriteTo.TestOutput(outputHelper) | |||
.CreateLogger(); | |||
|
|||
_initialStates = new State(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀
As there are
IAccountStateDelta
,IAccountState
, andIAccountDelta
as separate interfaces, the name ofState
class has been changed toStateDelta
to avoid future confusion. This is mainly a preparatory work to smooth over introducing a different and newState
class in a follow-up PR.Addendum: On second thought, to be safe, I'll be naming things
MockStateDelta
,MockDelta
, andMockState
to avoid mistakes.