-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ Modernize MockStateDelta
#1997
♻️ Modernize MockStateDelta
#1997
Conversation
.Lib9c.Tests/Action/Snapshot/transfer_asset.TransferCrystal.summary.verified.txt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for creating this MockStateDelta
, how do you envision it applying future changes to the IAccountStateDelta
to it?
I opened a PR to address it. |
5773057
to
9cb4127
Compare
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
@boscohyun @longfin
I'd like to add more to @longfin's PR and have it as a separate PR if possible. |
Many safety features have been turned off for test compatibility reasons. See the description for
MockStateDelta
for more detail.