Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backmerge 1.0.0 to development #2122

Merged
merged 18 commits into from
Sep 1, 2023
Merged

Backmerge 1.0.0 to development #2122

merged 18 commits into from
Sep 1, 2023

Conversation

U-lis
Copy link
Contributor

@U-lis U-lis commented Sep 1, 2023

SSIA

U-lis and others added 16 commits August 29, 2023 10:46
- Set default Exp for former equipments to 0
- Add GetRealExp function to get real exp of all equipments
Fix exp handling for former equipments
…lease/1.0.0

merge release/0.5.3 into release/1.0.0
- Get EquipmentItemSheet.Row by ID, not Grade and ItemSubType
    - It also needs ElementalType but ID can cover all conditions.
- Returns Exp field unconditionally. It has default value 0
Handle enhancement of level 0 to 0 case
Serialize Exp field only when it has positive value
@U-lis U-lis requested a review from a team September 1, 2023 02:52
@U-lis U-lis self-assigned this Sep 1, 2023
@area363
Copy link
Member

area363 commented Sep 1, 2023

@pull-request-quantifier-deprecated

This PR has 10 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +7 -3
Percentile : 4%

Total files changed: 2

Change summary by file extension:
.cs : +7 -3

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@U-lis U-lis disabled auto-merge September 1, 2023 05:23
@U-lis U-lis merged commit f537ee7 into development Sep 1, 2023
12 of 13 checks passed
@U-lis U-lis deleted the release/1.0.0 branch September 1, 2023 05:46
@U-lis U-lis restored the release/1.0.0 branch September 1, 2023 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants