-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backmerge 1.0.0 to development #2122
Conversation
- Set default Exp for former equipments to 0 - Add GetRealExp function to get real exp of all equipments
Fix exp handling for former equipments
# Conflicts: # Lib9c/ActionObsoleteConfig.cs
…lease/1.0.0 merge release/0.5.3 into release/1.0.0
- Get EquipmentItemSheet.Row by ID, not Grade and ItemSubType - It also needs ElementalType but ID can cover all conditions. - Returns Exp field unconditionally. It has default value 0
Handle enhancement of level 0 to 0 case
Serialize Exp field only when it has positive value
https://github.com/planetarium/lib9c/actions/runs/6044873874/job/16404089432?pr=2122#step:7:816 |
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
SSIA