-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add GetTxQuota to ACS #2194
add GetTxQuota to ACS #2194
Conversation
@Atralupus This PR replaces #2191 PTAL🙏 |
@moreal Suggestions are applied! cc @Atralupus |
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
@Atralupus PTAL one last time before merging 🙏 |
Changes
GetTxQuota
method toACS
to check a signer's individualtxQuotaPerSigner
when staging txs.Replaces #2191.