-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🧹 chore: cleanup lib9c service #2271
🧹 chore: cleanup lib9c service #2271
Conversation
14de212
to
049c1fd
Compare
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋🏻
Context
Since #2269, we use
Lib9c.Plugin
instead ofLib9c.StateService
andLibplanet.Extensions.RemoteActionEvaluator
. So we don't needLib9c.StateService
andLibplanet.Extensions.RemoteActionEvaluator
.Rationale
Remove
Lib9c.StateService
andLibplanet.Extensions.RemoteActionEvaluator
from the project. 👋