Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce Vampiric : ActionBuff #2274

Merged
merged 14 commits into from
Dec 6, 2023
Merged

Introduce Vampiric : ActionBuff #2274

merged 14 commits into from
Dec 6, 2023

Commits on Dec 6, 2023

  1. change GiveEffect to not absract method

    @sonohoshi
    sonohoshi committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    53dcaa4 View commit details
    Browse the repository at this point in the history

  2. introduce Vampiric action buff

    @sonohoshi
    sonohoshi committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    bf42751 View commit details
    Browse the repository at this point in the history

  3. add temporary csv for testing vampiric

    @sonohoshi
    sonohoshi committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    3e0bb5e View commit details
    Browse the repository at this point in the history

  4. add unit test about vampiric

    @sonohoshi
    sonohoshi committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    1ccf980 View commit details
    Browse the repository at this point in the history

  5. implement Vampiric.GiveEffectForArena

    @sonohoshi
    sonohoshi committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    0773da6 View commit details
    Browse the repository at this point in the history

  6. add temporary table sheets data for test

    @sonohoshi
    sonohoshi committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    b658dbd View commit details
    Browse the repository at this point in the history

  7. vampire data

    @NineSyu @sonohoshi
    NineSyu authored and sonohoshi committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    34905b8 View commit details
    Browse the repository at this point in the history

  8. Update Skill buff_type Change

    @NineSyu @sonohoshi
    NineSyu authored and sonohoshi committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    97ff327 View commit details
    Browse the repository at this point in the history

  9. fix unit test argument

    @sonohoshi
    sonohoshi committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    49fe6b3 View commit details
    Browse the repository at this point in the history

  10. change invoking timing the bleed and vampiric at OnPostSkill

    @sonohoshi
    sonohoshi committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    f627100 View commit details
    Browse the repository at this point in the history

  11. add CoCustomEvent to IStage and IArena 

    for smooth implmentation at client
    @sonohoshi
    sonohoshi committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    6448d0c View commit details
    Browse the repository at this point in the history

  12. fix unit test about Vampiric logging

    @sonohoshi
    sonohoshi committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    29cfc65 View commit details
    Browse the repository at this point in the history

  13. improve Vampiric unit test

    @sonohoshi
    sonohoshi committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    07c48b1 View commit details
    Browse the repository at this point in the history

  14. fix Vampiric calculating logic to using basis point from percent

    @sonohoshi
    sonohoshi committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    430145f View commit details
    Browse the repository at this point in the history