Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option count #2934

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Add option count #2934

merged 1 commit into from
Oct 25, 2024

Conversation

U-lis
Copy link
Contributor

@U-lis U-lis commented Oct 25, 2024

Add option count when new option or skill added

This PR resolves planetarium/NineChronicles#6225

@U-lis U-lis added the bug Something isn't working label Oct 25, 2024
@U-lis U-lis added this to the v240.0.0 milestone Oct 25, 2024
@U-lis U-lis requested a review from ipdae October 25, 2024 04:04
@U-lis U-lis self-assigned this Oct 25, 2024
ipdae
ipdae approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@ipdae ipdae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

핫픽스라 이 pr에선 진행안해도 되지만 후속 이슈를 만들어서 실수가 반복안되도록 장비에 옵션을 부여할때 이 필드값을 업데이트하는 메서드를 만들어서 쓰면 좋을것같습니다.

@U-lis U-lis mentioned this pull request Oct 25, 2024
Open
@U-lis U-lis merged commit d4cfc48 into release/1.19.0 Oct 25, 2024
15 checks passed
@U-lis U-lis deleted the bugfix/custom-craft/optioncount branch October 25, 2024 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ipdae ipdae ipdae approved these changes

Assignees

@U-lis U-lis

Labels
bug Something isn't working
Projects
Nine Chronicles
Status: Merged
Milestone
v240.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@U-lis @ipdae