Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Hong Minhee <hong.minhee@gmail.com>
  • Loading branch information
longfin and dahlia committed May 21, 2020
1 parent 6609354 commit b2ffe65
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ To be released.

### Backward-incompatible API changes

- Added `IAction.RenderError()` and `IAction.UnrenderError()`.
- Added `IAction.RenderError()` and `IAction.UnrenderError()` methods.
[[#860], [#875]]

### Backward-incompatible network protocol changes
Expand Down
2 changes: 1 addition & 1 deletion Libplanet/Action/ActionEvaluation.cs
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ public class ActionEvaluation
/// evaluate <paramref name="action"/>.</param>
/// <param name="outputStates">The result states that
/// <paramref name="action"/> makes.</param>
/// <param name="exception">An exception that has raised during evaluating a given
/// <param name="exception">An exception that has risen during evaluating a given
/// <paramref name="action"/>.</param>
public ActionEvaluation(
IAction action,
Expand Down
14 changes: 7 additions & 7 deletions Libplanet/Action/IAction.cs
Original file line number Diff line number Diff line change
Expand Up @@ -315,9 +315,9 @@ public interface IAction
void Render(IActionContext context, IAccountStateDelta nextStates);

/// <summary>
/// Does things that should be doen right after this action is
/// spread to the network or is &#x201c;confirmed&#x201d; (kind of)
/// by each peer node.
/// Does the similar things to <see cref="Render(IActionContext, IAccountStateDelta)"/>,
/// except that this method is invoked when see cref="Execute(IActionContext)"/> method
/// has terminated with an exception.
/// </summary>
/// <param name="context">The equivalent context object to
/// what <see cref="Execute(IActionContext)"/> method had received.
Expand Down Expand Up @@ -353,11 +353,11 @@ public interface IAction
void Unrender(IActionContext context, IAccountStateDelta nextStates);

/// <summary>
/// Does things that should be undone right after this action is
/// invalidated (mostly due to a block which this action has belonged
/// to becoming considered a stale).
/// Does the similar things to <see cref="Unrender(IActionContext, IAccountStateDelta)"/>,
/// except that this method is invoked when see cref="Execute(IActionContext)"/> method
/// has terminated with an exception.
/// <para>This method takes the equivalent arguments to
/// <see cref="Render(IActionContext, IAccountStateDelta)"/> method.
/// <see cref="RenderError(IActionContext, Exception)"/> method.
/// </para>
/// </summary>
/// <param name="context">The equivalent context object to
Expand Down

0 comments on commit b2ffe65

Please sign in to comment.