Enable null checker on exception files

[changelog skip]

CHANGES.md

@@ -116,11 +116,12 @@ To be released.
  -  `BlockPolicy<T>.DoesTransactionFollowPolicy()` method and
     `IBlockPolicy.DoesTransactionFollowPolicy()` method became to take
     additional `BlockChain<T>` parameter as its context.  [[#1012]]
- -  `doesTransactionFollowPolicy` parameter became 
+ -  `doesTransactionFollowPolicy` parameter became
     `Func<Transaction<T>, BlockChain<T>, bool>` on `BlockPolicy<T>()`
     constructor.  [[#1012]]
  -  Added `cacheSize` optional parameter to `BlockSet<T>()` constructor.
     [[#1013]]
+ -  Removed constructors from `InvalidMessageException` class.
 
 ### Backward-incompatible network protocol changes
 

Libplanet/Action/MissingActionTypeException.cs

@@ -1,3 +1,4 @@
+#nullable enable
 using System;
 
 namespace Libplanet.Action

Libplanet/Action/UnexpectedlyTerminatedActionException.cs

@@ -1,3 +1,4 @@
+#nullable enable
 using System;
 using System.Runtime.Serialization;
 using System.Security.Cryptography;
@@ -73,14 +74,39 @@ StreamingContext context
                 TxId = new TxId(txId);
             }
 
-            if (info.TryGetValue($"{nameof(Action)}_type", out string actionType))
+            string actionKey = $"{nameof(Action)}_type";
+            if (info.TryGetValue(actionKey, out string actionType))
             {
-                var values = (Dictionary)new Codec().Decode(
-                    info.GetValue<byte[]>($"{nameof(Action)}_values")
-                );
+                string valuesKey = $"{nameof(Action)}_values";
+                if (!(info.GetValue<byte[]>(valuesKey) is byte[] valuesBytes))
+                {
+                    throw new SerializationException($"Missing the {valuesKey} field.");
+                }
 
-                Action = (IAction)Activator.CreateInstance(Type.GetType(actionType, true, true));
-                Action?.LoadPlainValue(values);
+                if (!(new Codec().Decode(valuesBytes) is Dictionary values))
+                {
+                    throw new SerializationException(
+                        $"{valuesKey} field must be a Bencodex dictionary."
+                    );
+                }
+
+                Type type = Type.GetType(actionType, true, true)
+                    ?? throw new SerializationException($"Failed to find the type: {actionType}.");
+                if (Activator.CreateInstance(type) is IAction action)
+                {
+                    Action = action;
+                    Action.LoadPlainValue(values);
+                }
+                else
+                {
+                    throw new SerializationException(
+                        $"Failed to instantiate the action: {actionType}."
+                    );
+                }
+            }
+            else
+            {
+                throw new SerializationException($"Missing the {actionKey} field.");
             }
         }
 

Libplanet/Blockchain/IncompleteBlockStatesException.cs

@@ -1,3 +1,4 @@
+#nullable enable
 using System;
 using System.Security.Cryptography;
 using Libplanet.Blocks;
@@ -21,7 +22,7 @@ public class IncompleteBlockStatesException : Exception
         /// </param>
         public IncompleteBlockStatesException(
             HashDigest<SHA256> blockHash,
-            string message = null)
+            string? message = null)
             : base(
                 message is null
                     ? $"The block {blockHash} lacks its states"

Libplanet/Blocks/InvalidBlockDifficultyException.cs

@@ -1,3 +1,4 @@
+#nullable enable
 using System;
 
 namespace Libplanet.Blocks

Libplanet/Blocks/InvalidBlockException.cs

@@ -1,3 +1,4 @@
+#nullable enable
 using System;
 using System.Runtime.Serialization;
 

Libplanet/Blocks/InvalidBlockHashException.cs

@@ -1,3 +1,4 @@
+#nullable enable
 using System;
 
 namespace Libplanet.Blocks

Libplanet/Blocks/InvalidBlockIndexException.cs

@@ -1,3 +1,4 @@
+#nullable enable
 using System;
 
 namespace Libplanet.Blocks

Libplanet/Blocks/InvalidBlockPreviousHashException.cs

@@ -1,3 +1,4 @@
+#nullable enable
 using System;
 
 namespace Libplanet.Blocks

Libplanet/Blocks/InvalidBlockTimestampException.cs

@@ -1,3 +1,4 @@
+#nullable enable
 using System;
 
 namespace Libplanet.Blocks

Libplanet/Blocks/InvalidGenesisBlockException.cs

@@ -1,3 +1,4 @@
+#nullable enable
 using System.Diagnostics.Contracts;
 using System.Security.Cryptography;
 using Libplanet.Blockchain;

Libplanet/Crypto/InvalidCiphertextException.cs

@@ -1,3 +1,4 @@
+#nullable enable
 using System;
 using System.Runtime.Serialization;
 

Libplanet/KeyStore/IncorrectPassphraseException.cs

@@ -1,3 +1,4 @@
+#nullable enable
 using System;
 using System.Collections.Immutable;
 

Libplanet/KeyStore/InvalidKeyJsonException.cs

@@ -1,3 +1,4 @@
+#nullable enable
 namespace Libplanet.KeyStore
 {
     /// <summary>

Libplanet/KeyStore/KeyJsonException.cs

@@ -1,3 +1,4 @@
+#nullable enable
 using System;
 
 namespace Libplanet.KeyStore

Libplanet/KeyStore/KeyStoreException.cs

@@ -1,3 +1,4 @@
+#nullable enable
 using System;
 
 namespace Libplanet.KeyStore

Libplanet/KeyStore/MismatchedAddressException.cs

@@ -1,3 +1,4 @@
+#nullable enable
 using System;
 
 namespace Libplanet.KeyStore

Libplanet/KeyStore/NoKeyException.cs

@@ -1,3 +1,4 @@
+#nullable enable
 using System;
 
 namespace Libplanet.KeyStore

Libplanet/KeyStore/UnsupportedKeyJsonException.cs

@@ -1,3 +1,4 @@
+#nullable enable
 namespace Libplanet.KeyStore
 {
     /// <summary>

Libplanet/Net/DifferentAppProtocolVersionException.cs

@@ -1,3 +1,4 @@
+#nullable enable
 #pragma warning disable S3871
 using System;
 using Libplanet.Net.Messages;

Libplanet/Net/IceServerException.cs

@@ -1,3 +1,4 @@
+#nullable enable
 using System;
 
 namespace Libplanet.Net

Libplanet/Net/InvalidMessageException.cs

@@ -1,3 +1,4 @@
+#nullable enable
 using System;
 using System.Runtime.Serialization;
 using Libplanet.Net.Messages;
@@ -7,18 +8,14 @@ namespace Libplanet.Net
     [Serializable]
     public class InvalidMessageException : Exception
     {
-        public InvalidMessageException()
-        {
-        }
-
-        public InvalidMessageException(string message)
-            : base(message)
-        {
-        }
-
-        public InvalidMessageException(string message, Exception innerException)
+        internal InvalidMessageException(
+            string message,
+            Message receivedMessage,
+            Exception innerException
+        )
             : base(message, innerException)
         {
+            ReceivedMessage = receivedMessage;
         }
 
         internal InvalidMessageException(string message, Message receivedMessage)
@@ -33,8 +30,19 @@ StreamingContext context
         )
             : base(info, context)
         {
+            ReceivedMessage = info.GetValue(nameof(ReceivedMessage), typeof(Message)) is Message m
+                ? m
+                : throw new SerializationException(
+                    $"{nameof(ReceivedMessage)} is expected to be a non-null {nameof(Message)}.");
         }
 
         internal Message ReceivedMessage { get; }
+
+        public override void GetObjectData(
+            SerializationInfo info, StreamingContext context)
+        {
+            base.GetObjectData(info, context);
+            info.AddValue(nameof(ReceivedMessage), ReceivedMessage);
+        }
     }
 }

Libplanet/Net/InvalidStateTargetException.cs

@@ -1,3 +1,4 @@
+#nullable enable
 using System;
 using System.Runtime.Serialization;
 

Libplanet/Net/Messages/Message.cs

@@ -230,8 +230,10 @@ public static Message Parse(
 
             if (!types.TryGetValue(rawType, out Type type))
             {
-                throw new InvalidMessageException(
-                    $"Can't determine NetMQMessage. [type: {rawType}]");
+                throw new ArgumentException(
+                    $"Can't determine NetMQMessage. [type: {rawType}]",
+                    nameof(raw)
+                );
             }
 
             var message = (Message)Activator.CreateInstance(
@@ -241,9 +243,7 @@ public static Message Parse(
 
             if (!message.Remote.PublicKey.Verify(body.ToByteArray(), signature))
             {
-                throw new InvalidMessageException(
-                    "The message signature is invalid"
-                );
+                throw new InvalidMessageException("The message signature is invalid", message);
             }
 
             if (!reply)

Libplanet/Net/NoSwarmContextException.cs

@@ -1,3 +1,4 @@
+#nullable enable
 using System;
 using System.Runtime.Serialization;
 

Libplanet/Net/PeerNotFoundException.cs

@@ -1,3 +1,4 @@
+#nullable enable
 using System;
 using System.Runtime.Serialization;
 

Libplanet/Net/Protocols/KademliaProtocol.cs

@@ -423,20 +423,20 @@ internal async Task PingAsync(
             try
             {
                 _logger.Debug("Trying to ping async to {Peer}.", target);
-                if (!(await _transport.SendMessageWithReplyAsync(
+                Message reply = await _transport.SendMessageWithReplyAsync(
                     target,
                     new Ping(),
                     timeout,
-                    cancellationToken) is Pong pong))
+                    cancellationToken
+                );
+                if (!(reply is Pong pong))
                 {
-                    throw new InvalidMessageException(
-                        "Received pong is invalid.");
+                    throw new InvalidMessageException("Received pong is invalid.", reply);
                 }
 
                 if (pong.Remote.Address.Equals(_address))
                 {
-                    throw new InvalidMessageException(
-                        "Cannot receive pong from self");
+                    throw new InvalidMessageException("Cannot receive pong from self", pong);
                 }
             }
             catch (TimeoutException)
@@ -592,13 +592,18 @@ private async Task<IEnumerable<BoundPeer>> GetNeighbors(
             var findPeer = new FindNeighbors(target);
             try
             {
-                if (!(await _transport.SendMessageWithReplyAsync(
+                Message reply = await _transport.SendMessageWithReplyAsync(
                     addressee,
                     findPeer,
                     timeout,
-                    cancellationToken) is Neighbors neighbors))
+                    cancellationToken
+                );
+                if (!(reply is Neighbors neighbors))
                 {
-                    throw new InvalidMessageException("Reply of FindNeighbors is invalid.");
+                    throw new InvalidMessageException(
+                        $"Reply to {nameof(FindNeighbors)} is invalid.",
+                        reply
+                    );
                 }
 
                 return neighbors.Found;

Libplanet/Net/Protocols/PeerDiscoveryException.cs

@@ -1,3 +1,4 @@
+#nullable enable
 using System;
 using System.Runtime.Serialization;
 

Libplanet/Net/Protocols/PingTimeoutException.cs

@@ -1,3 +1,4 @@
+#nullable enable
 using System;
 using System.Runtime.Serialization;
 
@@ -27,7 +28,10 @@ public PingTimeoutException(BoundPeer target, string message, Exception innerExc
         protected PingTimeoutException(SerializationInfo info, StreamingContext context)
             : base(info, context)
         {
-            Target = (BoundPeer)info.GetValue("Target", typeof(BoundPeer));
+            Target = info.GetValue(nameof(Target), typeof(BoundPeer)) is BoundPeer target
+                ? target
+                : throw new SerializationException(
+                    $"{nameof(Target)} is expected to be a non-null {nameof(BoundPeer)}.");
         }
 
         public BoundPeer Target { get; private set; }
@@ -41,7 +45,7 @@ public override void GetObjectData(
             }
 
             base.GetObjectData(info, context);
-            info.AddValue("Target", Target);
+            info.AddValue(nameof(Target), Target);
         }
     }
 }

Libplanet/Net/Swarm.cs

@@ -1034,10 +1034,10 @@ internal async IAsyncEnumerable<Tuple<long, HashDigest<SHA256>>> GetBlockHashes(
                 yield break;
             }
 
-            throw new InvalidMessageException(
+            string errorMessage =
                 $"The response of {nameof(GetBlockHashes)} is expected to be " +
-                $"{nameof(BlockHashes)}, not {parsedMessage.GetType().Name}: {parsedMessage}"
-            );
+                $"{nameof(BlockHashes)}, not {parsedMessage.GetType().Name}: {parsedMessage}";
+            throw new InvalidMessageException(errorMessage, parsedMessage);
         }
 
         internal async IAsyncEnumerable<Block<T>> GetBlocksAsync(
@@ -1097,11 +1097,11 @@ [EnumeratorCancellation] CancellationToken cancellationToken
                 }
                 else
                 {
-                    throw new InvalidMessageException(
+                    string errorMessage =
                         $"Expected a {nameof(Blocks)} message as a response of " +
                         $"the {nameof(GetBlocks)} message, but got a {message.GetType().Name} " +
-                        $"message instead: {message}"
-                    );
+                        $"message instead: {message}";
+                    throw new InvalidMessageException(errorMessage, message);
                 }
             }
 
@@ -1146,11 +1146,11 @@ internal async IAsyncEnumerable<Transaction<T>> GetTxsAsync(
                 }
                 else
                 {
-                    throw new InvalidMessageException(
+                    string errorMessage =
                         $"Expected {nameof(Tx)} messages as response of " +
                         $"the {nameof(GetTxs)} message, but got a {message.GetType().Name} " +
-                        $"message instead: {message}"
-                    );
+                        $"message instead: {message}";
+                    throw new InvalidMessageException(errorMessage, message);
                 }
             }
         }

Libplanet/Net/SwarmException.cs

@@ -1,3 +1,4 @@
+#nullable enable
 using System;
 using System.Runtime.Serialization;
 

Libplanet/Store/ChainIdNotFoundException.cs

@@ -1,3 +1,4 @@
+#nullable enable
 using System;
 
 namespace Libplanet.Store

Libplanet/Tx/InvalidTxException.cs

@@ -1,3 +1,4 @@
+#nullable enable
 using System;
 
 namespace Libplanet.Tx