Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Caching Block<T>.Hash property #228

Closed
longfin opened this issue Apr 30, 2019 · 0 comments
Closed

Caching Block<T>.Hash property #228

longfin opened this issue Apr 30, 2019 · 0 comments
Assignees
@longfin
Labels
suggestion Suggestion or feature request

Comments

@longfin
Copy link
Member

longfin commented Apr 30, 2019

In the current implementation, Block<T>.Hash is calculated for each call. But we can easily cache Block <T> .Hash because Block<T> is assumed as an immutable, and it can lead to improved performance.
@longfin longfin added the suggestion Suggestion or feature request label Apr 30, 2019
@longfin longfin self-assigned this May 9, 2019
limebell pushed a commit to limebell/libplanet that referenced this issue Jul 7, 2021
@boscohyun
Merge pull request planetarium#228 from boscohyun/bug-fix/add-equals-…
ecd5358 
…method-to-costume

Add `Equals()` method to `Costume`
OnedgeLee pushed a commit to OnedgeLee/libplanet that referenced this issue Jan 31, 2023
@area363
Merge pull request planetarium#228 from planetarium/update-internal-m…
d4266f8 
…anifests-1674092261

fix formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@longfin longfin

Labels
suggestion Suggestion or feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@longfin