Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LiteDBStore.StoreStateReference() appends entries in an inefficient way #395

Closed
dahlia opened this issue Aug 5, 2019 · 0 comments
Closed

LiteDBStore.StoreStateReference() appends entries in an inefficient way #395

dahlia opened this issue Aug 5, 2019 · 0 comments
Assignees
@dahlia
Labels
bug Something isn't working
Milestone
0.5.0

Comments

@dahlia
Copy link
Contributor

dahlia commented Aug 5, 2019

The current implementation of LiteDBStore.StoreStateReference() method reads all the existing set and then appends a new entry to the set in memory, and then replaces the entire set with a new entire set. This should be replaced by an efficient append operation.
@dahlia dahlia added the bug Something isn't working label Aug 5, 2019
@dahlia dahlia added this to the 0.5.0 milestone Aug 5, 2019
@dahlia dahlia self-assigned this Aug 5, 2019
dahlia added a commit to dahlia/libplanet that referenced this issue Aug 5, 2019
@dahlia
More efficient way to store state references
1baadf8 
Fix planetarium#395
@dahlia dahlia mentioned this issue Aug 5, 2019
Merged
dahlia added a commit to dahlia/libplanet that referenced this issue Aug 6, 2019
@dahlia
More efficient way to store state references
338cf86 
Fix planetarium#395
dahlia added a commit to dahlia/libplanet that referenced this issue Aug 6, 2019
@dahlia
More efficient way to store state references
8df25b3 
Fix planetarium#395
@dahlia dahlia closed this as completed Aug 6, 2019
longfin pushed a commit to longfin/libplanet.net that referenced this issue Aug 6, 2019
@dahlia @longfin
More efficient way to store state references
a64e71b 
Fix planetarium#395
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dahlia dahlia

Labels
bug Something isn't working
Projects
None yet
Milestone
0.5.0
Development

No branches or pull requests
1 participant
@dahlia