Improve performance of BlockSet<T>
#1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longfin
force-pushed
the
feature/cache-blockset
branch
from
bc44027
to
ddd571b
Compare
longfin
requested review from
limebell,
dahlia,
earlbread,
moreal and
riemannulus
moreal
previously approved these changes
Sep 22, 2020
Codecov Report
@@ Coverage Diff @@
## main #1013 +/- ##
==========================================
- Coverage 89.00% 88.84% -0.16%
==========================================
Files 330 330
Lines 29897 29918 +21
==========================================
- Hits 26609 26580 -29
- Misses 1717 1765 +48
- Partials 1571 1573 +2
|
longfin
force-pushed
the
feature/cache-blockset
branch
from
ddd571b
to
97504af
Compare
moreal
previously approved these changes
Sep 22, 2020
earlbread
reviewed
Sep 23, 2020
earlbread
previously approved these changes
Sep 23, 2020
limebell
reviewed
Sep 23, 2020
longfin
commented
Sep 23, 2020
|
There was an error handling pipeline event 1419a0be-8d39-45de-a9fb-53f57bffac73. |
earlbread
previously approved these changes
Sep 23, 2020
moreal
previously approved these changes
Sep 23, 2020
riemannulus
previously approved these changes
Sep 23, 2020
dahlia
reviewed
Sep 23, 2020
longfin
dismissed stale reviews from riemannulus, moreal, and earlbread
via
9545d57
Co-authored-by: Hong Minhee (洪 民憙) <hong.minhee@gmail.com>
dahlia
approved these changes
Sep 23, 2020
limebell
approved these changes
Sep 23, 2020
earlbread
approved these changes
Sep 23, 2020
moreal
approved these changes
Sep 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a cache to
BlockSet<T>to improve its fetching performance. (it can be useful when blocks contain huge and complex actions.)