Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed retrying logic when block downloading #1062

Merged
merged 1 commit into from
Oct 30, 2020

Conversation

longfin
Copy link
Member

@longfin longfin commented Oct 30, 2020

SSIA

@longfin longfin self-assigned this Oct 30, 2020
@longfin longfin marked this pull request as ready for review October 30, 2020 07:19
@codecov
Copy link

codecov bot commented Oct 30, 2020

Codecov Report

Merging #1062 into 9c-main will decrease coverage by 0.83%.
The diff coverage is 94.44%.

@@             Coverage Diff             @@
##           9c-main    #1062      +/-   ##
===========================================
- Coverage    88.26%   87.42%   -0.84%     
===========================================
  Files          343      312      -31     
  Lines        31511    30053    -1458     
===========================================
- Hits         27812    26274    -1538     
- Misses        2023     2120      +97     
+ Partials      1676     1659      -17     
Impacted Files Coverage Δ
Libplanet/Net/Swarm.cs 84.33% <94.44%> (+0.94%) ⬆️
Libplanet.Stun/Stun/Attributes/Nonce.cs 0.00% <0.00%> (-100.00%) ⬇️
Libplanet.Stun/Stun/Attributes/Realm.cs 0.00% <0.00%> (-100.00%) ⬇️
Libplanet.Stun/Stun/Attributes/Software.cs 0.00% <0.00%> (-100.00%) ⬇️
Libplanet.Stun/Stun/Attributes/ErrorCode.cs 0.00% <0.00%> (-100.00%) ⬇️
Libplanet.Stun/Stun/Messages/RefreshRequest.cs 0.00% <0.00%> (-100.00%) ⬇️
Libplanet.Stun/Stun/Attributes/MessageIntegrity.cs 0.00% <0.00%> (-100.00%) ⬇️
...planet.Stun/Stun/Messages/AllocateErrorResponse.cs 0.00% <0.00%> (-55.56%) ⬇️
...anet.Stun/Stun/Attributes/StunAddressExtensions.cs 37.77% <0.00%> (-40.01%) ⬇️
...bplanet.Stun/Stun/Messages/RefreshErrorResponse.cs 0.00% <0.00%> (-40.00%) ⬇️
... and 40 more

@longfin longfin merged commit 1185973 into planetarium:9c-main Oct 30, 2020
@moreal moreal mentioned this pull request Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants