Break when getting blocks count is less then hash chunk size #1112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dahlia
reviewed
Nov 26, 2020
limebell
reviewed
Nov 26, 2020
longfin
reviewed
Nov 26, 2020
limebell
reviewed
Nov 26, 2020
riemannulus
force-pushed
the
fix/fillblock
branch
2 times, most recently
from
09fb3be
to
969588c
Compare
longfin
previously approved these changes
Nov 26, 2020
riemannulus
force-pushed
the
fix/fillblock
branch
from
969588c
to
5ce6db6
Compare
longfin
previously approved these changes
Nov 26, 2020
dahlia
reviewed
Nov 26, 2020
riemannulus
force-pushed
the
fix/fillblock
branch
2 times, most recently
from
07de4d4
to
6eee1ae
Compare
dahlia
previously approved these changes
Nov 26, 2020
longfin
previously approved these changes
Nov 26, 2020
riemannulus
force-pushed
the
fix/fillblock
branch
from
6eee1ae
to
00ec961
Compare
riemannulus
pushed a commit
that referenced
this pull request
Nov 30, 2020
Test for break when getting blocks count is less then hash chunk size #1112
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If getting blocks size in
Swarm<T>.FillBlocksAsync()is less thenSwarm<T>.FindNextHashesChunkSize, it means getting all of blocks in this try. So, do not processing next step for check.