-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate peer discovery from transport #1120
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1120 +/- ##
==========================================
- Coverage 87.58% 87.55% -0.04%
==========================================
Files 341 341
Lines 29747 29694 -53
==========================================
- Hits 26055 25999 -56
- Misses 2057 2065 +8
+ Partials 1635 1630 -5
|
72ca5e0
to
fc76c34
Compare
700bd3d
to
e6e77a6
Compare
_requestTimeout = | ||
requestTimeout ?? | ||
TimeSpan.FromMilliseconds(Kademlia.IdleRequestTimeout); | ||
TimeSpan.FromMilliseconds(5000); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it okay we use 5000
directly instead of named constant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought it is weird that timeout value is located at Kademlia constants.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to need to resolve conflict 🙏
public int Count => _buckets.Sum(bucket => bucket.Count); | ||
|
||
/// <summary> | ||
/// <see cref="IEnumerable{T}"/> of peers in the table. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/// <see cref="IEnumerable{T}"/> of peers in the table. | |
/// A list of peers in the table. |
With the XML document, we will see a strange sentence like the below link.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
40f5945
to
492e586
Compare
492e586
to
c68aa9f
Compare
c68aa9f
to
c7dee8f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be rebased again.
c7dee8f
to
c71cff4
Compare
Introduce Kademlia class to public
And made some methods to internal
c71cff4
to
62dc896
Compare
This patch separates peer discovery logic from transport.
Skipped changelog for
NetMQTransport
constructor because it is added in 0.11.