Separate peer discovery from transport #1120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1120 +/- ##
==========================================
- Coverage 87.58% 87.55% -0.04%
==========================================
Files 341 341
Lines 29747 29694 -53
==========================================
- Hits 26055 25999 -56
- Misses 2057 2065 +8
+ Partials 1635 1630 -5
|
limebell
force-pushed
the
refactor/protocol
branch
from
72ca5e0
to
fc76c34
Compare
limebell
requested review from
dahlia,
longfin,
moreal and
riemannulus
and removed request for
dahlia
limebell
force-pushed
the
refactor/protocol
branch
3 times, most recently
from
700bd3d
to
e6e77a6
Compare
longfin
reviewed
Dec 4, 2020
longfin
reviewed
Dec 4, 2020
longfin
previously approved these changes
Dec 4, 2020
| _requestTimeout = | ||
| requestTimeout ?? | ||
| TimeSpan.FromMilliseconds(Kademlia.IdleRequestTimeout); | ||
| TimeSpan.FromMilliseconds(5000); |
There was a problem hiding this comment.
Is it okay we use 5000 directly instead of named constant?
There was a problem hiding this comment.
I thought it is weird that timeout value is located at Kademlia constants.
moreal
reviewed
Dec 7, 2020
| public int Count => _buckets.Sum(bucket => bucket.Count); | ||
|
|
||
| /// <summary> | ||
| /// <see cref="IEnumerable{T}"/> of peers in the table. |
There was a problem hiding this comment.
Suggested change
| /// <see cref="IEnumerable{T}"/> of peers in the table. | |
| /// A list of peers in the table. |
With the XML document, we will see a strange sentence like the below link.
Closed
limebell
force-pushed
the
refactor/protocol
branch
from
40f5945
to
492e586
Compare
dahlia
previously approved these changes
Dec 8, 2020
limebell
force-pushed
the
refactor/protocol
branch
from
492e586
to
c68aa9f
Compare
longfin
previously approved these changes
Dec 10, 2020
moreal
previously approved these changes
Dec 10, 2020
limebell
force-pushed
the
refactor/protocol
branch
from
c68aa9f
to
c7dee8f
Compare
limebell
force-pushed
the
refactor/protocol
branch
from
c7dee8f
to
c71cff4
Compare
moreal
previously approved these changes
Dec 15, 2020
dahlia
previously approved these changes
Dec 15, 2020
longfin
previously approved these changes
Dec 16, 2020
Introduce Kademlia class to public
And made some methods to internal
limebell
force-pushed
the
refactor/protocol
branch
from
c71cff4
to
62dc896
Compare
longfin
approved these changes
Dec 16, 2020
moreal
approved these changes
Dec 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch separates peer discovery logic from transport.
Skipped changelog for
NetMQTransportconstructor because it is added in 0.11.