feat(cli): provide useful commands #1137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moreal
force-pushed
the
feature/cli/mpt-list-query
branch
from
3047fb5
to
2f6409f
Compare
longfin
previously approved these changes
Dec 23, 2020
Codecov Report
@@ Coverage Diff @@
## main #1137 +/- ##
==========================================
- Coverage 87.56% 87.54% -0.02%
==========================================
Files 345 345
Lines 30012 30012
==========================================
- Hits 26279 26274 -5
- Misses 2101 2108 +7
+ Partials 1632 1630 -2
|
limebell
previously approved these changes
Dec 24, 2020
longfin
previously approved these changes
Jan 4, 2021
dahlia
reviewed
Jan 4, 2021
CHANGES.md
Outdated
| @@ -111,6 +111,7 @@ To be released. | |||
| [[#1129]] | |||
| - Store aliases used by `planet mpt` became to disallow names looking like | |||
| URIs to disambiguate aliases from the literal store URIs. [[#1129]] | |||
| - Added a new sub-command `planet mpt list` and `planet mpt query`. [[#1137]] | |||
There was a problem hiding this comment.
Suggested change
| - Added a new sub-command `planet mpt list` and `planet mpt query`. [[#1137]] | |
| - Added new subcommands `planet mpt list` and `planet mpt query`. [[#1137]] |
FYI English speakers seems to prefer “subcommand” without a hyphen (about 787,000 results on Google) over “sub-command” with a hyphen (about 154,000 results on Google).
There was a problem hiding this comment.
I amended it in adefc27.
dahlia
previously approved these changes
Jan 4, 2021
riemannulus
previously approved these changes
Jan 4, 2021
moreal
force-pushed
the
feature/cli/mpt-list-query
branch
from
b7471f2
to
2ff10aa
Compare
|
I pushed again in force because there was an issue at Azure Pipelines CI. I couldn't find the way to restart them so I pushed again. But there are no changes after @riemannulus @dahlia approved. You can check it with GitHub compare b7471f..2ff10a. Please review again 🙏 |
moreal
force-pushed
the
feature/cli/mpt-list-query
branch
from
2ff10aa
to
83679b4
Compare
limebell
previously approved these changes
Jan 4, 2021
dahlia
previously approved these changes
Jan 4, 2021
moreal
force-pushed
the
feature/cli/mpt-list-query
branch
from
83679b4
to
e1610d9
Compare
riemannulus
previously approved these changes
Jan 5, 2021
dahlia
previously approved these changes
Jan 5, 2021
moreal
force-pushed
the
feature/cli/mpt-list-query
branch
from
e1610d9
to
d1dd447
Compare
"It didn't …" → "It doesn't …" Co-Authored-By: Swen Mun <longfinfunnel@gmail.com> Co-Authored-By: Chanhyuck <lime_bell@naver.com>
Co-Authored-By: Hong Minhee <hong.minhee@gmail.com>
Co-Authored-By: Hong Minhee <hong.minhee@gmail.com>
Co-Authored-By: Hong Minhee <hong.minhee@gmail.com>
moreal
force-pushed
the
feature/cli/mpt-list-query
branch
from
d1dd447
to
a13ce71
Compare
|
@planetarium/libplanet PTAL 🙏 |
longfin
approved these changes
Jan 6, 2021
riemannulus
approved these changes
Jan 6, 2021
dahlia
approved these changes
Jan 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It provides:
mpt list: List all aliases stored.mpt query KV-STORE STATE-ROOT-HASH STATE-KEY: query a state of the state key at the state root hash in kv-store.