-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use protocol version of existing block #1162
fix: use protocol version of existing block #1162
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1162 +/- ##
==========================================
+ Coverage 87.54% 87.59% +0.05%
==========================================
Files 350 350
Lines 30475 30488 +13
==========================================
+ Hits 26678 26706 +28
+ Misses 2100 2083 -17
- Partials 1697 1699 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a link to this pull request on the relevant changelogs?
Lines 11 to 14 in cd982b6
- Added the parameter `protocolVersion` to `Block<T>(long, long, BigInteger, | |
Nonce, Address?, HashDigest<SHA256>?, DateTimeOffset, | |
IEnumerable<Transaction<T>> transactions, HashDigest<SHA256>?, | |
HashDigest<SHA256>?)` constructor. [[#1142], [#1147]] |
Lines 99 to 102 in cd982b6
- Introduced the [protocol versioning scheme][#1142]. This purposes to change | |
the protocol without breaking backward compatibility. Even the protocol | |
is changed, the existing blocks made before the new protocol are guaranteed | |
to behave as it had done. [[#1142], [#1147]] |
194cd56
to
b9e6c9e
Compare
b9e6c9e
to
605cb5b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SSIA.