-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lifespan to messages #1171
Merged
limebell
merged 9 commits into
planetarium:main
from
limebell:feature/message-timestamp
Jan 29, 2021
Merged
Add lifespan to messages #1171
limebell
merged 9 commits into
planetarium:main
from
limebell:feature/message-timestamp
Jan 29, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
limebell
requested review from
dahlia,
longfin,
riemannulus,
moreal and
area363
January 27, 2021 05:13
Codecov Report
@@ Coverage Diff @@
## main #1171 +/- ##
===========================================
- Coverage 87.58% 72.56% -15.02%
===========================================
Files 355 61 -294
Lines 31022 1604 -29418
===========================================
- Hits 27171 1164 -26007
+ Misses 2102 368 -1734
+ Partials 1749 72 -1677
|
limebell
force-pushed
the
feature/message-timestamp
branch
from
January 29, 2021 02:00
a0d47d8
to
3c973e9
Compare
dahlia
reviewed
Jan 29, 2021
riemannulus
reviewed
Jan 29, 2021
limebell
force-pushed
the
feature/message-timestamp
branch
from
January 29, 2021 08:11
3c973e9
to
d66f2fd
Compare
dahlia
reviewed
Jan 29, 2021
dahlia
reviewed
Jan 29, 2021
dahlia
previously approved these changes
Jan 29, 2021
longfin
previously approved these changes
Jan 29, 2021
The unit test fails on
|
dahlia
approved these changes
Jan 29, 2021
longfin
approved these changes
Jan 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added timestamp to messages. Network transport used in swarm will now ignore messages created in certain time before current time, or after current moment. The amount of lifespan of a message is configured in
SwarmOptions.MessageLifespan
, ifnull
is given then timestamp will not being used in message validation.There are API changes in
Message
, but I omitted it in the changelog because the abstract classMessage
haven't released yet.Please refer to #1160.