Partitioning database for block and transaction #1194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1194 +/- ##
==========================================
- Coverage 87.49% 87.41% -0.09%
==========================================
Files 360 360
Lines 31607 31724 +117
==========================================
+ Hits 27656 27730 +74
- Misses 2175 2207 +32
- Partials 1776 1787 +11
|
longfin
reviewed
Feb 26, 2021
dahlia
reviewed
Feb 26, 2021
riemannulus
changed the title
Co-authored-by: Hong.Minhee <hong.minhee@planetariumhq.com>
Co-authored-by: Hong.Minhee <hong.minhee@planetariumhq.com>
riemannulus
force-pushed
the
feature/distribute-database
branch
from
ba49cfe
to
0917653
Compare
|
PTAL 🙏 @libplanet |
longfin
previously approved these changes
Mar 3, 2021
limebell
previously approved these changes
Mar 4, 2021
Co-authored-by: Swen Mun <swen@planetariumhq.com>
|
PTAL 🙏 @planetarium/libplanet |
longfin
approved these changes
Mar 5, 2021
area363
approved these changes
Mar 5, 2021
limebell
approved these changes
Mar 5, 2021
dahlia
reviewed
Mar 5, 2021
Comment on lines
+78
to
+81
| /// <param name="txEpochUnitSeconds">The number of Transaction to store in DB | ||
| /// for each epoch. 86400 by default.</param> | ||
| /// <param name="blockEpochUnitSeconds">The number of block to store in DB | ||
| /// for each epoch. 86400 by default.</param> |
There was a problem hiding this comment.
The docs seem incorrect; aren't they seconds (not # of txs/blocks)?
The number of Transaction
The number of block
dahlia
added a commit
to dahlia/libplanet
that referenced
this pull request
Mar 5, 2021
dahlia
added a commit
to dahlia/libplanet
that referenced
this pull request
Apr 14, 2021
dahlia
added a commit
to dahlia/libplanet
that referenced
this pull request
Apr 14, 2021
dahlia
added a commit
to dahlia/libplanet
that referenced
this pull request
Apr 15, 2021
dahlia
added a commit
to dahlia/libplanet
that referenced
this pull request
Apr 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snapshots are getting bigger. As of
Feb 17 and 2021, it maintains about 1.0-1.1GB, which means that 1.0-1.1GB of files are downloaded every time the user plays the game. It is also a problem that even if the DAU becomes 2 million, about 200GB of CF CDN fee will be charged, but receiving 1.1GB of files every time is indeed a burden for users.For this reason, there is a need to partition the database so that it can incrementally receive snapshots.
This PR is making transactions and blocks stored in a partitioned database.