Make Swarm<T>.RefreshTableAsync config constants configurable and change structure of PeerState
#1215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1215 +/- ##
==========================================
+ Coverage 86.01% 86.12% +0.11%
==========================================
Files 361 361
Lines 32463 32492 +29
==========================================
+ Hits 27922 27984 +62
+ Misses 2757 2723 -34
- Partials 1784 1785 +1
|
dahlia
reviewed
Mar 17, 2021
longfin
previously approved these changes
Mar 17, 2021
moreal
reviewed
Mar 18, 2021
limebell
force-pushed
the
feature/configurable-constants
branch
from
e2d4a9f
to
9a41cac
Compare
longfin
reviewed
Mar 19, 2021
limebell
force-pushed
the
feature/configurable-constants
branch
from
9a41cac
to
e9c7a4b
Compare
dahlia
previously approved these changes
Mar 22, 2021
moreal
reviewed
Mar 22, 2021
|
Since |
moreal
reviewed
Mar 23, 2021
dahlia
previously approved these changes
Mar 23, 2021
limebell
force-pushed
the
feature/configurable-constants
branch
from
6966c2b
to
b0d0442
Compare
riemannulus
previously approved these changes
Mar 23, 2021
limebell
force-pushed
the
feature/configurable-constants
branch
from
b0d0442
to
1dabbcc
Compare
limebell
force-pushed
the
feature/configurable-constants
branch
from
1dabbcc
to
7152bf6
Compare
dahlia
approved these changes
Mar 26, 2021
longfin
approved these changes
Mar 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two changes:
SwarmOptions.RefreshPeriodandSwarmOptions.RefreshLifespanwhich configures refresh of routing table. It have 10 seconds and 60 seconds as its default value.PeerState.Address, addedPeerState.Peerinstead which has more information.This contains one backward incompatible change and one behavioral change, please feel free two tell me if it will be better to separate two patches into two pull requests.