Peer.EndPoints to Peer.EndPoint #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longfin
force-pushed
the
feature/unify-peer-endpoint
branch
from
b1cb9b5
to
b3cdd49
Compare
|
Some tests seem to fail. I'll fix it. |
dahlia
reviewed
Mar 11, 2019
CHANGES.md
Outdated
| @@ -6,7 +6,7 @@ Version 0.2.0 | |||
|
|
|||
| To be released. | |||
|
|
|||
| - The type of `Peer.Urls` property is changed from `Uri` to `IPEndPoint`. | |||
| - `Peer.Urls` is changed to `Peer.EndPoint` represented as single `IPEndPoint`. | |||
There was a problem hiding this comment.
There were a renaming and a retyping, so we'd better to sum up the explanation at higher view, with links to the issue #120 and #126.
- Since we decided to depend on TURN (RFC 5766) and STUN (RFC 5389) to work around NAT so that
Peer's endpoints don't have to be multiple,Peer.Urlswas renamed toPeer.EndPointand its type also was changed fromIImmutableList<Uri>toIPEndPoint. [Change type of Peer.Urls to IPEndPoint #120, Turn Peer.Endpoints to Peer.Endpoint #126]
Codecov Report
@@ Coverage Diff @@
## master #127 +/- ##
==========================================
+ Coverage 88.12% 88.18% +0.05%
==========================================
Files 61 61
Lines 3015 2987 -28
==========================================
- Hits 2657 2634 -23
+ Misses 358 353 -5
|
longfin
force-pushed
the
feature/unify-peer-endpoint
branch
from
b3cdd49
to
92da26d
Compare
dahlia
approved these changes
Mar 11, 2019
dahlia
pushed a commit
to dahlia/libplanet
that referenced
this pull request
Mar 9, 2021
…difficulty feat: support totalDifficulty field
OnedgeLee
pushed a commit
to OnedgeLee/libplanet
that referenced
this pull request
Jan 31, 2023
…headless-metrics-aggregator/update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces
Peer.EndPointswithPeer.EndPoint. (as suggested in #126)