-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI for TxId
→ BlockHash
index
#1340
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1340 +/- ##
==========================================
- Coverage 86.03% 77.08% -8.96%
==========================================
Files 361 253 -108
Lines 32457 17070 -15387
==========================================
- Hits 27925 13158 -14767
- Misses 2747 3375 +628
+ Partials 1785 537 -1248
|
Please resolve conflict in changelog. |
PTAL. |
/rebase |
1af6c67
to
5bbb16f
Compare
private readonly Transaction<Utils.DummyAction> _transaction1; | ||
private readonly Transaction<Utils.DummyAction> _transaction2; | ||
private readonly Transaction<Utils.DummyAction> _transaction3; | ||
private readonly Transaction<Utils.DummyAction> _transaction4; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about making an array?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure about the benefit of doing that.
Is there any weak point declaring 4 individual variables in this test case? @limebell
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just because it's clean? Not a strong suggestion though. Please check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO, those variables don't share any semantics, such as living in the same block or signed by the same signer, in the following testcases. So I think that there is no need to aggregate them. And the beauty or cleanliness of code is up to the individuals unless it does not break the coding rule(lint)
Hence If you don't mind, may I keep them as a separate variable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🆗
TxId
→ BlockHash
index
/rebase |
Co-authored-by: Swen Mun <longfinfunnel@gmail.com>
closes #1316
add commands for indexing TxId->BlockHash