Fail-fast when block sync #1350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longfin
force-pushed
the
feature/tune-swarm-blocksync
branch
2 times, most recently
from
026ec04
to
a5f2174
Compare
longfin
added
bug
auto-assign
bot
requested review from
dahlia,
greymistcube,
limebell and
riemannulus
Codecov Report
@@ Coverage Diff @@
## main #1350 +/- ##
==========================================
- Coverage 86.03% 76.92% -9.12%
==========================================
Files 361 253 -108
Lines 32457 16982 -15475
==========================================
- Hits 27925 13063 -14862
- Misses 2747 3397 +650
+ Partials 1785 522 -1263
|
limebell
reviewed
Jun 24, 2021
| ) < 0 | ||
| && (canonComparer.Compare( | ||
| blockChain.PerceiveBlock(blockChain.Tip), | ||
| blockChain.PerceiveBlock(syncedB.Tip)) < 0 |
There was a problem hiding this comment.
Is it okay without PerceivedTime?
There was a problem hiding this comment.
I think it's okay because BlockChain<T>.PerceiveBlock() uses perceivedTime only when the given excerpt is not found on its own storage. cc @dahlia
limebell
previously approved these changes
Jun 24, 2021
|
/rebase |
libplanet
force-pushed
the
feature/tune-swarm-blocksync
branch
from
a5f2174
to
a32320f
Compare
limebell
previously approved these changes
Jun 29, 2021
longfin
force-pushed
the
feature/tune-swarm-blocksync
branch
from
a32320f
to
99dd04d
Compare
dahlia
previously approved these changes
Jul 2, 2021
longfin
force-pushed
the
feature/tune-swarm-blocksync
branch
from
99dd04d
to
b1c65b8
Compare
limebell
previously approved these changes
Jul 5, 2021
|
/rebase |
libplanet
force-pushed
the
feature/tune-swarm-blocksync
branch
from
b1c65b8
to
61f989b
Compare
dahlia
approved these changes
Jul 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes null check before chain swapping when block synchronization. it's to fail quickly instead of malfunctioning when a problem situation such as #1349