Prevent ObjectDisposedException during NetMQTransport.DoBroadcast() #1365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-assign
bot
requested review from
dahlia,
greymistcube,
longfin and
riemannulus
limebell
force-pushed
the
bugfix/prevent-dealer-ode
branch
from
2707304
to
02f8493
Compare
Codecov Report
@@ Coverage Diff @@
## main #1365 +/- ##
==========================================
- Coverage 77.32% 77.12% -0.20%
==========================================
Files 256 253 -3
Lines 17230 17092 -138
==========================================
- Hits 13323 13183 -140
- Misses 3360 3374 +14
+ Partials 547 535 -12
|
longfin
previously approved these changes
Jul 2, 2021
kfangw
previously approved these changes
Jul 2, 2021
CHANGES.md
Outdated
| @@ -320,6 +322,8 @@ To be released. | |||
| [#1343]: https://github.com/planetarium/libplanet/pull/1343 | |||
| [#1348]: https://github.com/planetarium/libplanet/pull/1348 | |||
| [#1351]: https://github.com/planetarium/libplanet/pull/1351 | |||
| [#1363]: https://github.com/planetarium/libplanet/issues/1363 | |||
There was a problem hiding this comment.
Thanks for your review. Amended in 0b325f9
limebell
force-pushed
the
bugfix/prevent-dealer-ode
branch
2 times, most recently
from
0d16847
to
62379b9
Compare
limebell
added
bug
limebell
force-pushed
the
bugfix/prevent-dealer-ode
branch
from
62379b9
to
0b325f9
Compare
limebell
force-pushed
the
bugfix/prevent-dealer-ode
branch
from
0b325f9
to
44e33e1
Compare
dahlia
approved these changes
Jul 28, 2021
This was referenced Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This occurs intermittently, but when it occur,
Swarm<T>stops. This patch fixes the case whenObjectDisposedExceptionoccurs. Closes #1361 and #1362.