-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent ObjectDisposedException during NetMQTransport.DoBroadcast() #1365
Prevent ObjectDisposedException during NetMQTransport.DoBroadcast() #1365
Conversation
2707304
to
02f8493
Compare
Codecov Report
@@ Coverage Diff @@
## main #1365 +/- ##
==========================================
- Coverage 77.32% 77.12% -0.20%
==========================================
Files 256 253 -3
Lines 17230 17092 -138
==========================================
- Hits 13323 13183 -140
- Misses 3360 3374 +14
+ Partials 547 535 -12
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit.
CHANGES.md
Outdated
@@ -320,6 +322,8 @@ To be released. | |||
[#1343]: https://github.com/planetarium/libplanet/pull/1343 | |||
[#1348]: https://github.com/planetarium/libplanet/pull/1348 | |||
[#1351]: https://github.com/planetarium/libplanet/pull/1351 | |||
[#1363]: https://github.com/planetarium/libplanet/issues/1363 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your review. Amended in 0b325f9
0d16847
to
62379b9
Compare
62379b9
to
0b325f9
Compare
0b325f9
to
44e33e1
Compare
This occurs intermittently, but when it occur,
Swarm<T>
stops. This patch fixes the case whenObjectDisposedException
occurs. Closes #1361 and #1362.