Non-blocking renderers #1422
Merged
Non-blocking renderers #1422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dahlia
force-pushed
the
nonblock-renderers
branch
from
ca25c6e
to
0d01119
Compare
Codecov Report
@@ Coverage Diff @@
## main #1422 +/- ##
==========================================
- Coverage 77.30% 77.27% -0.04%
==========================================
Files 256 258 +2
Lines 17225 17318 +93
==========================================
+ Hits 13316 13382 +66
- Misses 3358 3380 +22
- Partials 551 556 +5
|
limebell
previously approved these changes
Aug 3, 2021
longfin
reviewed
Aug 3, 2021
| /// Queues the callback to be executed in the worker thread. | ||
| /// </summary> | ||
| /// <param name="action">The callback to be executed in the worker thread.</param> | ||
| protected void Queue(System.Action action) |
There was a problem hiding this comment.
It also looks similar toTaskScheduler.QueueTask. It would have been nice to be able to use an implementation like SingleThreadedTaskScheduler, but there is no implementation in advance. 😢
|
@planetarium/libplanet Addressed requested changes. Please review this again! |
longfin
previously approved these changes
Aug 5, 2021
limebell
previously approved these changes
Aug 5, 2021
[changelog skip]
dahlia
force-pushed
the
nonblock-renderers
branch
from
5685b13
to
e95b70d
Compare
limebell
approved these changes
Aug 5, 2021
longfin
approved these changes
Aug 5, 2021
This was referenced Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements #1402.
Relevant pull requests on Nine Chronicles: