-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non-blocking renderers #1422
Non-blocking renderers #1422
Conversation
ca25c6e
to
0d01119
Compare
Codecov Report
@@ Coverage Diff @@
## main #1422 +/- ##
==========================================
- Coverage 77.30% 77.27% -0.04%
==========================================
Files 256 258 +2
Lines 17225 17318 +93
==========================================
+ Hits 13316 13382 +66
- Misses 3358 3380 +22
- Partials 551 556 +5
|
/// Queues the callback to be executed in the worker thread. | ||
/// </summary> | ||
/// <param name="action">The callback to be executed in the worker thread.</param> | ||
protected void Queue(System.Action action) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It also looks similar toTaskScheduler.QueueTask
. It would have been nice to be able to use an implementation like SingleThreadedTaskScheduler
, but there is no implementation in advance. 😢
@planetarium/libplanet Addressed requested changes. Please review this again! |
[changelog skip]
5685b13
to
e95b70d
Compare
This implements #1402.
Relevant pull requests on Nine Chronicles: