Throw exception when action type is not annotated #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #144 +/- ##
==========================================
- Coverage 87.72% 84.89% -2.84%
==========================================
Files 69 70 +1
Lines 3250 3263 +13
==========================================
- Hits 2851 2770 -81
- Misses 399 493 +94
|
dahlia
reviewed
Mar 22, 2019
longfin
reviewed
Mar 22, 2019
earlbread
force-pushed
the
invalid-action-type-exception
branch
2 times, most recently
from
6699605
to
9ecf915
Compare
dahlia
previously approved these changes
Mar 22, 2019
longfin
reviewed
Mar 22, 2019
earlbread
force-pushed
the
invalid-action-type-exception
branch
from
9ecf915
to
0b34c49
Compare
longfin
approved these changes
Mar 23, 2019
dahlia
pushed a commit
to dahlia/libplanet
that referenced
this pull request
Mar 9, 2021
…t-20210105 Bump libplanet to 0.11.0-dev.20201209085742
OnedgeLee
pushed a commit
to OnedgeLee/libplanet
that referenced
this pull request
Jan 31, 2023
…ests-1669622808 Update main manifests [update-main-manifests-1669622808]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InvalidActionTypeExceptionif an action type is not annotated withactionTypeAttribute. Should check and warn if an action type is not annotated with ActionTypeAttribute #28