Make BlockChain<T>.GetStates() to only drill down until all requested addresses are found #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longfin
reviewed
Apr 12, 2019
dahlia
force-pushed
the
fix-get-states-unnecessary-deep-down
branch
from
06f459b
to
e9025a2
Compare
longfin
previously approved these changes
Apr 12, 2019
earlbread
previously approved these changes
Apr 12, 2019
dahlia
force-pushed
the
fix-get-states-unnecessary-deep-down
branch
from
e9025a2
to
d447970
Compare
earlbread
approved these changes
Apr 12, 2019
longfin
approved these changes
Apr 12, 2019
Codecov Report
@@ Coverage Diff @@
## 0.2-maintenance #192 +/- ##
===================================================
- Coverage 87.18% 84.07% -3.11%
===================================================
Files 71 71
Lines 3245 3246 +1
===================================================
- Hits 2829 2729 -100
- Misses 416 517 +101
|
limebell
pushed a commit
to limebell/libplanet
that referenced
this pull request
Jul 7, 2021
Fix tx patchtable sub-command
OnedgeLee
pushed a commit
to OnedgeLee/libplanet
that referenced
this pull request
Jan 31, 2023
…netarium#192) * INTERNAL: update configmap-versions.yaml * INTERNAL: update kustomization.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixed a part of the issue #189. (For the case of nonexistent addresses, as it needs to change
IStoreinterface to fix that, I am going to submit a separated patch to the master.)The problem is that the condition to test if all requested addresses are satisfied had depended on the order of two sets of addresses, which is arbitrary. I wrote a regression test to reproduce this problem, which involves testing utilities like
NullPolicy<T>andStoreTracker, and fixed it by replacingSequenceEquals()withSetEquals().