Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry refreshing when stale nonce error occurred #193

Merged
merged 1 commit into from
Apr 12, 2019

Conversation

longfin
Copy link
Member

@longfin longfin commented Apr 12, 2019

This PR fixes TurnClient to retry RefreshAllocation when stale nonce error occurred.

Copy link
Contributor

@dahlia dahlia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be also good if we write a short changelog:

Fixed a bug that TurnClientException had been thrown by Swarm when a STUN nonce is stale.

@codecov
Copy link

codecov bot commented Apr 12, 2019

Codecov Report

Merging #193 into master will decrease coverage by 3.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #193      +/-   ##
==========================================
- Coverage   87.26%   84.22%   -3.04%     
==========================================
  Files          72       72              
  Lines        3291     3291              
==========================================
- Hits         2872     2772     -100     
- Misses        419      519     +100
Impacted Files Coverage Δ
Libplanet/Net/IceServer.cs 0% <0%> (-100%) ⬇️
Libplanet/Net/IceServerException.cs 0% <0%> (-100%) ⬇️
Libplanet/Net/NetworkStreamProxy.cs 0% <0%> (-80.77%) ⬇️
Libplanet/Net/Swarm.cs 82.55% <0%> (-5.14%) ⬇️

@longfin longfin merged commit 559bf86 into planetarium:master Apr 12, 2019
limebell pushed a commit to limebell/libplanet that referenced this pull request Jul 7, 2021
OnedgeLee pushed a commit to OnedgeLee/libplanet that referenced this pull request Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants