Fix disconnecting on TURN relay session #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
earlbread
reviewed
Apr 15, 2019
longfin
force-pushed
the
bugfix/disconnect-turn
branch
from
10a73a1
to
adc4e46
Compare
Codecov Report
@@ Coverage Diff @@
## master #198 +/- ##
==========================================
- Coverage 84.44% 84.22% -0.22%
==========================================
Files 72 72
Lines 3350 3367 +17
==========================================
+ Hits 2829 2836 +7
- Misses 521 531 +10
|
longfin
force-pushed
the
bugfix/disconnect-turn
branch
from
adc4e46
to
f1831c9
Compare
|
I've rebased. |
earlbread
previously approved these changes
Apr 15, 2019
dahlia
reviewed
Apr 15, 2019
| @@ -33,6 +33,9 @@ public partial class Swarm : ICollection<Peer>, IDisposable | |||
| private static readonly TimeSpan TurnAllocationLifetime = | |||
| TimeSpan.FromSeconds(777); | |||
|
|
|||
| private static readonly TimeSpan TurnPermissionLifetime = | |||
| TimeSpan.FromMinutes(5); | |||
There was a problem hiding this comment.
Is this time interval defined by the specification, or just arbitrary? If it's arbitrary, it would be good to parametrize this.
There was a problem hiding this comment.
It was defined in RFC.
The Permission Lifetime MUST be 300 seconds (= 5 minutes).
There was a problem hiding this comment.
Good to link to that in a comment.
longfin
force-pushed
the
bugfix/disconnect-turn
branch
from
ee6913a
to
27dd93a
Compare
Co-Authored-By: longfin <longfinfunnel@gmail.com>
Co-Authored-By: longfin <longfinfunnel@gmail.com>
longfin
force-pushed
the
bugfix/disconnect-turn
branch
from
27dd93a
to
a84e576
Compare
dahlia
approved these changes
Apr 15, 2019
limebell
pushed a commit
to limebell/libplanet
that referenced
this pull request
Jul 7, 2021
…changed-state Reduce GetState, SetState call count in IAction.Execute
OnedgeLee
pushed a commit
to OnedgeLee/libplanet
that referenced
this pull request
Jan 31, 2023
chore: Use slack webhook [internal]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aids problem the problem of TURN relay session being disconnected. if the TURN server doesn't receive
CreatePermissionon time, it deletes the registered peer and rejects any request from that. to prevent this, I added a task that iteratesCreatePermission.It also fixes the following issues:
Swarmattempted to use TURN relay even though_hostwas given.Append()to increase parallelism.