-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix disconnecting on TURN relay session #198
Conversation
10a73a1
to
adc4e46
Compare
Codecov Report
@@ Coverage Diff @@
## master #198 +/- ##
==========================================
- Coverage 84.44% 84.22% -0.22%
==========================================
Files 72 72
Lines 3350 3367 +17
==========================================
+ Hits 2829 2836 +7
- Misses 521 531 +10
|
adc4e46
to
f1831c9
Compare
I've rebased. |
@@ -33,6 +33,9 @@ public partial class Swarm : ICollection<Peer>, IDisposable | |||
private static readonly TimeSpan TurnAllocationLifetime = | |||
TimeSpan.FromSeconds(777); | |||
|
|||
private static readonly TimeSpan TurnPermissionLifetime = | |||
TimeSpan.FromMinutes(5); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this time interval defined by the specification, or just arbitrary? If it's arbitrary, it would be good to parametrize this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was defined in RFC.
The Permission Lifetime MUST be 300 seconds (= 5 minutes).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to link to that in a comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've mentioned.
ee6913a
to
27dd93a
Compare
Co-Authored-By: longfin <longfinfunnel@gmail.com>
Co-Authored-By: longfin <longfinfunnel@gmail.com>
27dd93a
to
a84e576
Compare
…changed-state Reduce GetState, SetState call count in IAction.Execute
chore: Use slack webhook [internal]
This PR aids problem the problem of TURN relay session being disconnected. if the TURN server doesn't receive
CreatePermission
on time, it deletes the registered peer and rejects any request from that. to prevent this, I added a task that iteratesCreatePermission
.It also fixes the following issues:
Swarm
attempted to use TURN relay even though_host
was given.Append()
to increase parallelism.