-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Swarm broadcasting #218
Conversation
191beee
to
a7b489d
Compare
@@ -87,6 +91,7 @@ public class Swarm : ICollection<Peer>, IDisposable | |||
PrivateKey privateKey, | |||
int appProtocolVersion, | |||
TimeSpan dialTimeout, | |||
TimeSpan linger, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A naming suggestion: how about gracePeriod
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gracePeriod
is also good, but I think linger
is general enough to explain this behavior.
967fc95
to
ce36224
Compare
2800642
to
25e357f
Compare
Codecov Report
@@ Coverage Diff @@
## master #218 +/- ##
========================================
- Coverage 84.1% 83.9% -0.2%
========================================
Files 75 75
Lines 3491 3504 +13
========================================
+ Hits 2936 2940 +4
- Misses 555 564 +9
|
Codecov Report
@@ Coverage Diff @@
## master #218 +/- ##
==========================================
- Coverage 84.1% 84.02% -0.09%
==========================================
Files 75 75
Lines 3492 3505 +13
==========================================
+ Hits 2937 2945 +8
- Misses 555 560 +5
|
87fe742
to
b912321
Compare
Co-Authored-By: longfin <longfinfunnel@gmail.com>
Co-Authored-By: longfin <longfinfunnel@gmail.com>
7b989af
to
62873e4
Compare
Codecov Report
@@ Coverage Diff @@
## master #218 +/- ##
==========================================
- Coverage 84.1% 83.56% -0.54%
==========================================
Files 75 75
Lines 3491 3511 +20
==========================================
- Hits 2936 2934 -2
- Misses 555 577 +22
|
Codecov Report
@@ Coverage Diff @@
## master #218 +/- ##
========================================
- Coverage 84.1% 83.9% -0.2%
========================================
Files 75 75
Lines 3491 3504 +13
========================================
+ Hits 2936 2940 +4
- Misses 555 564 +9
|
5e2bedb
to
bd38510
Compare
I've add some commits to aid the unit tests. PTAL @dahlia @earlbread |
{ | ||
if (_removedPeers.ContainsKey(peer)) | ||
{ | ||
_removedPeers.Remove(peer); | ||
} | ||
} | ||
|
||
var existingKeys = new HashSet<PublicKey>( | ||
_peers.Keys.Select(p => p.PublicKey) | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has this been unnecessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's unnecessary because there is no usage in this scope.
Co-Authored-By: longfin <longfinfunnel@gmail.com>
- Remove unused variable declarations & codes - Add assertions and type matching about type casting - Avoid multiple iteration using IEnumerable
- Force dotcover ignore other build processes. - Increate travis_wait time to 60 minutes. - Kill dotnet server after building
c3cd022
to
c198bc9
Compare
Update submodule: Libplanet
[Fix] Rollback wait pod script
This PR changes the broadcasting mechanism from TAP to
NetMQPoller
based to prevent unexpected behavior on multi threading environment. to accomplish it, it made some interface changes that convert some asynchronous methods to sync methods.Also, it adds time out on the unit tests to investigate the test freezing and fixes some problems in CI environment.