Fix Swarm broadcasting #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longfin
force-pushed
the
feature/swarm-broadcast
branch
3 times, most recently
from
191beee
to
a7b489d
Compare
earlbread
reviewed
Apr 26, 2019
dahlia
reviewed
Apr 26, 2019
| @@ -87,6 +91,7 @@ public class Swarm : ICollection<Peer>, IDisposable | |||
| PrivateKey privateKey, | |||
| int appProtocolVersion, | |||
| TimeSpan dialTimeout, | |||
| TimeSpan linger, | |||
There was a problem hiding this comment.
A naming suggestion: how about gracePeriod?
There was a problem hiding this comment.
gracePeriod is also good, but I think linger is general enough to explain this behavior.
longfin
force-pushed
the
feature/swarm-broadcast
branch
from
967fc95
to
ce36224
Compare
earlbread
previously approved these changes
Apr 26, 2019
longfin
force-pushed
the
feature/swarm-broadcast
branch
12 times, most recently
from
2800642
to
25e357f
Compare
Codecov Report
@@ Coverage Diff @@
## master #218 +/- ##
========================================
- Coverage 84.1% 83.9% -0.2%
========================================
Files 75 75
Lines 3491 3504 +13
========================================
+ Hits 2936 2940 +4
- Misses 555 564 +9
|
Codecov Report
@@ Coverage Diff @@
## master #218 +/- ##
==========================================
- Coverage 84.1% 84.02% -0.09%
==========================================
Files 75 75
Lines 3492 3505 +13
==========================================
+ Hits 2937 2945 +8
- Misses 555 560 +5
|
longfin
force-pushed
the
feature/swarm-broadcast
branch
4 times, most recently
from
87fe742
to
b912321
Compare
Co-Authored-By: longfin <longfinfunnel@gmail.com>
Co-Authored-By: longfin <longfinfunnel@gmail.com>
longfin
force-pushed
the
feature/swarm-broadcast
branch
from
7b989af
to
62873e4
Compare
Codecov Report
@@ Coverage Diff @@
## master #218 +/- ##
==========================================
- Coverage 84.1% 83.56% -0.54%
==========================================
Files 75 75
Lines 3491 3511 +20
==========================================
- Hits 2936 2934 -2
- Misses 555 577 +22
|
Codecov Report
@@ Coverage Diff @@
## master #218 +/- ##
========================================
- Coverage 84.1% 83.9% -0.2%
========================================
Files 75 75
Lines 3491 3504 +13
========================================
+ Hits 2936 2940 +4
- Misses 555 564 +9
|
longfin
force-pushed
the
feature/swarm-broadcast
branch
from
5e2bedb
to
bd38510
Compare
|
I've add some commits to aid the unit tests. PTAL @dahlia @earlbread |
dahlia
reviewed
May 8, 2019
| { | ||
| if (_removedPeers.ContainsKey(peer)) | ||
| { | ||
| _removedPeers.Remove(peer); | ||
| } | ||
| } | ||
|
|
||
| var existingKeys = new HashSet<PublicKey>( | ||
| _peers.Keys.Select(p => p.PublicKey) | ||
| ); |
There was a problem hiding this comment.
Yes, it's unnecessary because there is no usage in this scope.
Co-Authored-By: longfin <longfinfunnel@gmail.com>
- Remove unused variable declarations & codes - Add assertions and type matching about type casting - Avoid multiple iteration using IEnumerable
- Force dotcover ignore other build processes. - Increate travis_wait time to 60 minutes. - Kill dotnet server after building
longfin
force-pushed
the
feature/swarm-broadcast
branch
from
c3cd022
to
c198bc9
Compare
earlbread
approved these changes
May 9, 2019
dahlia
approved these changes
May 9, 2019
limebell
pushed a commit
to limebell/libplanet
that referenced
this pull request
Jul 7, 2021
Update submodule: Libplanet
OnedgeLee
pushed a commit
to OnedgeLee/libplanet
that referenced
this pull request
Jan 31, 2023
[Fix] Rollback wait pod script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the broadcasting mechanism from TAP to
NetMQPollerbased to prevent unexpected behavior on multi threading environment. to accomplish it, it made some interface changes that convert some asynchronous methods to sync methods.Also, it adds time out on the unit tests to investigate the test freezing and fixes some problems in CI environment.