-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate BlockCommit
while in BlockChain<T>.Append()
#2561
Validate BlockCommit
while in BlockChain<T>.Append()
#2561
Conversation
BlockCommit
while in Block<T>.Append()
BlockCommit
while in BlockChain<T>.Append()
c0fc510
to
0571cc3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add one line in "Behavioral changes" section that BlockChain<T>.Append()
became to throw an InvalidBlockCommitException
? And also <exception cref>
tag in the document of BlockChain<T>.Append()
method?
0571cc3
to
082fac8
Compare
082fac8
to
ec46764
Compare
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
Resolves #2541
This PR adds validation of
BlockCommit
inBlockChain<T>.Append()
.There are some cases we should consider:
PreloadAfterReorg
is failing but there will be no reorganization in PBFT, so skipped the test (Reorganization code should be removed.)