-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made BlockChain<T>.GetNonce() to refer staged transactions #270
Made BlockChain<T>.GetNonce() to refer staged transactions #270
Conversation
7765313
to
ed25fa0
Compare
Codecov Report
@@ Coverage Diff @@
## master #270 +/- ##
==========================================
+ Coverage 86.96% 87.01% +0.05%
==========================================
Files 180 180
Lines 11389 11432 +43
==========================================
+ Hits 9904 9948 +44
Misses 1241 1241
+ Partials 244 243 -1
|
Codecov Report
@@ Coverage Diff @@
## master #270 +/- ##
==========================================
+ Coverage 86.96% 87.11% +0.15%
==========================================
Files 180 180
Lines 11389 11444 +55
==========================================
+ Hits 9904 9970 +66
+ Misses 1241 1231 -10
+ Partials 244 243 -1
|
ed25fa0
to
0b89584
Compare
0b89584
to
007856b
Compare
I've added two changes.
|
I've changed BlockChain.GetNonce() to refer staged transactions without any other options. |
Could you let me know why did you removed that option? |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I wanted to minimize the options that users could make mistakes
Pair enough. In this perspective, we should eventually get rid of this method at all and make users able to make transactions without knowing the concept of tx nonce.
Co-Authored-By: Hong Minhee <hong.minhee@gmail.com>
This PR addsincludeStage
toBlockChain<T>.GetNonce()
to refer staged transactions during nonce computation.I've changed
BlockChain<T>.GetNonce()
to refer staged transactions without any other options.