Fix Swarm.StopAsync() #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #275 +/- ##
=========================================
- Coverage 87.04% 86.9% -0.14%
=========================================
Files 180 180
Lines 11532 11555 +23
=========================================
+ Hits 10038 10042 +4
- Misses 1250 1270 +20
+ Partials 244 243 -1
|
longfin
force-pushed
the
bugfix/swarm-stop
branch
5 times, most recently
from
6ad80f7
to
48e3704
Compare
longfin
force-pushed
the
bugfix/swarm-stop
branch
from
48e3704
to
268147f
Compare
earlbread
reviewed
Jun 10, 2019
earlbread
previously approved these changes
Jun 10, 2019
dahlia
previously approved these changes
Jun 10, 2019
Co-Authored-By: Seunghun Lee <waydi1@gmail.com>
longfin
force-pushed
the
bugfix/swarm-stop
branch
from
91048ce
to
1091414
Compare
dahlia
approved these changes
Jun 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issues as below.
Swarm.StopAsync()didn't stop properly duringSwarm.Preload()CancellationTokenon TAP methods.