Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send multiple blocks in one message #276

Merged
merged 2 commits into from
Jun 5, 2019

Conversation

earlbread
Copy link
Contributor

@earlbread earlbread commented Jun 5, 2019

This makes Swarm send and receive multiple blocks with one message instead of one block per message. #273

@earlbread earlbread self-assigned this Jun 5, 2019
@codecov
Copy link

codecov bot commented Jun 5, 2019

Codecov Report

Merging #276 into master will increase coverage by 0.02%.
The diff coverage is 92.66%.

@@            Coverage Diff             @@
##           master     #276      +/-   ##
==========================================
+ Coverage   87.03%   87.06%   +0.02%     
==========================================
  Files         180      180              
  Lines       11444    11532      +88     
==========================================
+ Hits         9960    10040      +80     
- Misses       1241     1249       +8     
  Partials      243      243
Impacted Files Coverage Δ
Libplanet/Net/Swarm.cs 75.29% <100%> (+0.33%) ⬆️
Libplanet.Tests/Net/SwarmTest.cs 93.08% <100%> (+0.52%) ⬆️
Libplanet/Net/Messages/Message.cs 83.63% <100%> (ø) ⬆️
Libplanet/Net/Messages/GetBlocks.cs 88.23% <69.23%> (-11.77%) ⬇️
Libplanet/Net/Messages/Blocks.cs 84.61% <84.61%> (ø)

@earlbread earlbread force-pushed the get-blocks branch 3 times, most recently from b2c6ac0 to 8e672ec Compare June 5, 2019 06:21
@earlbread earlbread marked this pull request as ready for review June 5, 2019 07:16
@earlbread earlbread requested review from longfin and dahlia and removed request for longfin June 5, 2019 07:16
Libplanet/Net/Swarm.cs Outdated Show resolved Hide resolved
Libplanet/Net/Swarm.cs Outdated Show resolved Hide resolved
Libplanet/Net/Swarm.cs Outdated Show resolved Hide resolved
Libplanet/Net/Swarm.cs Outdated Show resolved Hide resolved
Libplanet/Net/Swarm.cs Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
Libplanet/Net/Messages/Blocks.cs Show resolved Hide resolved
Libplanet/Net/Messages/Message.cs Outdated Show resolved Hide resolved
@earlbread earlbread force-pushed the get-blocks branch 3 times, most recently from 8f3134d to 9012f05 Compare June 5, 2019 08:39
@earlbread
Copy link
Contributor Author

I applied the review suggestions. Please take a look.

@dahlia dahlia added this to the 0.4.0 milestone Jun 5, 2019
@earlbread earlbread merged commit 2cd3480 into planetarium:master Jun 5, 2019
@earlbread earlbread deleted the get-blocks branch June 5, 2019 08:47
limebell pushed a commit to limebell/libplanet that referenced this pull request Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants