@planetarium/account-aws-kms

[tkiapril]

This PR introduces @planetarium/account-aws-kms, which provides AwsKmsAccount and AwsKmsKeyStore that uses AWS KMS as backend.

Also, it fixes the case where Signature in @planetarium/account accepts a high-S signature.

[codecov]

Codecov Report

Merging #2962 (24b0a1f) into main (bb3de0b) will decrease coverage by 0.06%.
The diff coverage is n/a.

❗ Current head 24b0a1f differs from pull request most recent head ff2b26f. Consider uploading reports for the commit ff2b26f to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2962      +/-   ##
==========================================
- Coverage   80.58%   80.53%   -0.06%     
==========================================
  Files         330      330              
  Lines       11774    11774              
==========================================
- Hits         9488     9482       -6     
- Misses       2286     2292       +6     

see 6 files with indirect coverage changes

[Akamig]

It seems pretty completed and working now, so let's just merge this then preparing new noble/secp256k1 in seperate issue/PR. shall we?

[pull-request-quantifier-deprecated]

This PR has 669 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

---

Quantification details

Label      : Extra Large
Size       : +657 -12
Percentile : 88.97%

Total files changed: 32

Change summary by file extension:
.sh : +1 -0
.yml : +7 -1
.yaml : +24 -3
.json : +53 -1
.gitignore : +2 -0
.md : +70 -5
.ts : +500 -2
.lock : +0 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

• Fast and predictable releases to production:
  • Optimal size changes are more likely to be reviewed faster with fewer
    iterations.
  • Similarity in low PR complexity drives similar review times.
• Review quality is likely higher as complexity is lower:
  • Bugs are more likely to be detected.
  • Code inconsistencies are more likely to be detected.
• Knowledge sharing is improved within the participants:
  • Small portions can be assimilated better.
• Better engineering practices are exercised:
  • Solving big problems by dividing them in well contained, smaller problems.
  • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

• Use the PullRequestQuantifier to quantify your PR accurately
  • Create a context profile for your repo using the context generator
  • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
  • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
  • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
• Change your engineering behaviors
  • For PRs that fall outside of the desired spectrum, review the details and check if:
    • Your PR could be split in smaller, self-contained PRs instead
    • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

• One line was added: +1 -0
• One line was deleted: +0 -1
• One line was modified: +1 -1 (git diff doesn't know about modified, it will
  interpret that line like one addition plus one deletion)
• Change percentiles: Change characteristics (addition, deletion, modification)
  of this PR in relation to all other PRs within the repository.

---

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.