Improve TurnClient connection #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longfin
force-pushed
the
feature/ensure-turn-connection
branch
2 times, most recently
from
cb5a2a7
to
b272c40
Compare
earlbread
reviewed
Jun 27, 2019
dahlia
reviewed
Jun 27, 2019
Codecov Report
@@ Coverage Diff @@
## master #308 +/- ##
==========================================
- Coverage 87.6% 87.45% -0.16%
==========================================
Files 187 187
Lines 12677 12690 +13
==========================================
- Hits 11106 11098 -8
- Misses 1322 1343 +21
Partials 249 249
|
longfin
force-pushed
the
feature/ensure-turn-connection
branch
2 times, most recently
from
7f40945
to
d777c2c
Compare
longfin
force-pushed
the
feature/ensure-turn-connection
branch
from
d777c2c
to
c176346
Compare
earlbread
previously approved these changes
Jun 27, 2019
dahlia
previously approved these changes
Jun 27, 2019
|
I've added 1c914ed to avoid |
dahlia
reviewed
Jun 27, 2019
longfin
force-pushed
the
feature/ensure-turn-connection
branch
from
1c914ed
to
f7362fa
Compare
dahlia
approved these changes
Jun 27, 2019
earlbread
approved these changes
Jun 27, 2019
This was referenced Jul 4, 2019
limebell
pushed a commit
to limebell/libplanet
that referenced
this pull request
Jul 7, 2021
Merge branch `rc-v100032` into main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds improves connectivity of
TurnClient._controlby addingTurnClient.EnsureConnectionto ensure_controlconnection before processing.