Make Swarm constructor have BlockChain<T> #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longfin
previously approved these changes
Jul 3, 2019
Codecov Report
@@ Coverage Diff @@
## master #324 +/- ##
==========================================
- Coverage 87.39% 87.28% -0.11%
==========================================
Files 189 189
Lines 12744 12769 +25
==========================================
+ Hits 11137 11145 +8
- Misses 1355 1374 +19
+ Partials 252 250 -2
|
earlbread
force-pushed
the
swarm-blockchain2
branch
from
40768b2
to
55db2e0
Compare
longfin
reviewed
Jul 3, 2019
dahlia
changed the title
dahlia
reviewed
Jul 3, 2019
earlbread
force-pushed
the
swarm-blockchain2
branch
2 times, most recently
from
894a900
to
395299b
Compare
dahlia
reviewed
Jul 3, 2019
longfin
reviewed
Jul 3, 2019
Codecov Report
@@ Coverage Diff @@
## master #324 +/- ##
==========================================
- Coverage 87.39% 87.34% -0.05%
==========================================
Files 189 189
Lines 12744 12767 +23
==========================================
+ Hits 11137 11151 +14
- Misses 1355 1366 +11
+ Partials 252 250 -2
|
Co-Authored-By: Swen Mun <longfinfunnel@gmail.com>
Co-Authored-By: Hong Minhee <hong.minhee@gmail.com>
earlbread
force-pushed
the
swarm-blockchain2
branch
from
9c8b25d
to
ee7ce65
Compare
|
Applied review comments. Please take a look. |
dahlia
approved these changes
Jul 3, 2019
longfin
approved these changes
Jul 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
Swarmconstructor receiveBlockChain<T>and have a type parameterT.